-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: limit orders quote wiring #8095
Conversation
f6a539f
to
1a874c1
Compare
7af99b2
to
22eaf88
Compare
1a874c1
to
0e299a9
Compare
e425f74
to
756c0ee
Compare
blame woody if those go haywire - but only 1 review needed here :) 💀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code point of view looks very sane, big tree @woodenfurniture 🐐
Testing at runtime: https://jam.dev/c/85d588ef-05e2-43a3-a714-04134c0719ba
A few things:
-
0$ is supposed to say
Free
as a green field as regular swapper does
-
Same as inverting, if you look at https://jam.dev/c/85d588ef-05e2-43a3-a714-04134c0719ba , there is a moment where you have USDC > FOX, with
When price reach 16
, which should be0.06
instead, I think it's due to the useEffect that is not rerunning on market price change and then if you click on the percent, it's populating the right ratio
Regular trade
Seems ok so far
src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderConfig.tsx
Show resolved
Hide resolved
src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderInput.tsx
Show resolved
Hide resolved
src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderInput.tsx
Show resolved
Hide resolved
756c0ee
to
2c0ee18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary seems like before
Slippage is rightly applied on a LI.FI swap
https://jam.dev/c/cb1cf9d0-4476-4953-9bd0-7fef0beda757
THORChain swap
https://jam.dev/c/e58929e6-6bb3-4e09-84b8-96bc6b284a30
memo is assuming 0.0006ETH as a receive amount vs 0.00067 estimated which is around 9.5 slippage, looking good
As long as it's behind a feature flag, limit order issues are not blocking and can be done in the next PR 👍
Appreciate the stamp, I've fixed both bugs in #8112: |
Description
Wires up the limit order quote query to the input and config UIs to display the result of the quote in the UI.
Includes:
%
input - not the input UI). Config is not reset when amounts or quote changes to avoid annoying users during polling (polling yet to be implemented)Excludes the following which are coming in follow-ups:
Issue (if applicable)
closes #8033
Risk
Majority of the change is behind a feature flag and is low risk, but as this refactors trade UI (
ConfirmSummary
andSlippagePopover
) this technically has to be marked as high risk.Testing
Testing should be focused on regressions for trades:
ConfirmSummary
is correctEngineering
Operations
Screenshots (if applicable)
https://jam.dev/c/18e12936-6779-4a97-a2f7-181406ab0098