refactor(blockifier): refactor default testing resource bounds

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• test(blockifier): migrate remaining tests to all resource bounds (except execution flavors test) #1342
• test(blockifier): parametrize more tests in transactions_test by resource bounds types #1337
• test(blockifier): parametrize test_actual_fee_gt_resource_bounds by resource bounds types #1330
• test(blockifier): parametrize test_max_fee_exceeds_balance by resource bounds types #1322
• test(blockifier): parametrize test_invoke_tx by resource bounds types #1321
• test(blockifier): update test_revert_on_resource_overuse to include new resource bounds #1314
• test(blockifier): update test_insufficient_max_fee_reverts to include new resource bounds #1313
• test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312
• test(blockifier): test enforce_fee flag with new resource bounds #1311
• test(blockifier): l1 bounds -> all bounds in stack trace test #1310
• test(blockifier): l1 bounds -> all bounds in worker logic test #1309
• test(blockifier): l1 bounds -> all bounds in versioned state test #1308
• test(blockifier): add all resource bounds to stateful validator test #1307
• refactor(blockifier): refactor default testing resource bounds #1306 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[dorimedini-starkware]

• test(blockifier): l1 bounds -> all bounds in worker logic test #1309
• test(blockifier): l1 bounds -> all bounds in versioned state test #1308
• test(blockifier): add all resource bounds to stateful validator test #1307
• refactor(blockifier): refactor default testing resource bounds #1306 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.94%. Comparing base (b0cfe82) to head (068214d).
Report is 382 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   74.18%   71.94%   -2.25%     
==========================================
  Files         359      357       -2     
  Lines       36240    37960    +1720     
  Branches    36240    37960    +1720     
==========================================
+ Hits        26886    27310     +424     
- Misses       7220     8534    +1314     
+ Partials     2134     2116      -18     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.035 ms 34.153 ms 34.351 ms]
change: [-6.3293% -4.7101% -3.1494%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
4 (4.00%) high mild
4 (4.00%) high severe

[yoavGrs]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/blockifier/src/test_utils.rs line 100 at r1 (raw file):

// The max_fee / resource bounds used for txs in this test.
// V3 transactions:
pub const DEFAULT_L1_GAS_AMOUNT: GasAmount = GasAmount(1000000);

Suggestion:

u64::pow(10, 6)

---

crates/blockifier/src/test_utils.rs line 120 at r1 (raw file):

// The amount of test-token allocated to the account in this test, set to a multiple of the max
// amount deprecated / non-deprecated transactions commit to paying.
pub const BALANCE: Fee = Fee(10

Move this definition after DEFAULT_ALL_BOUNDS_COMMITTED_FEE

Code quote:

BALANCE

---

crates/blockifier/src/test_utils.rs line 122 at r1 (raw file):

pub const BALANCE: Fee = Fee(10
    * const_max(
        const_max(DEFAULT_ALL_BOUNDS_COMMITTED_FEE.0, DEFAULT_L1_BOUNDS_COMMITTED_FEE.0),

Is there a case whereDEFAULT_ALL_BOUNDS_COMMITTED_FEE.0 < DEFAULT_L1_BOUNDS_COMMITTED_FEE.0?

Code quote:

const_max(DEFAULT_ALL_BOUNDS_COMMITTED_FEE.0, DEFAULT_L1_BOUNDS_COMMITTED_FEE.0),

[dorimedini-starkware]

Reviewable status: 9 of 13 files reviewed, 3 unresolved discussions (waiting on @yoavGrs)

---

crates/blockifier/src/test_utils.rs line 100 at r1 (raw file):

// The max_fee / resource bounds used for txs in this test.
// V3 transactions:
pub const DEFAULT_L1_GAS_AMOUNT: GasAmount = GasAmount(1000000);

Done.

---

crates/blockifier/src/test_utils.rs line 120 at r1 (raw file):

Previously, yoavGrs wrote…

Move this definition after DEFAULT_ALL_BOUNDS_COMMITTED_FEE

Done.

---

crates/blockifier/src/test_utils.rs line 122 at r1 (raw file):

Previously, yoavGrs wrote…

Is there a case whereDEFAULT_ALL_BOUNDS_COMMITTED_FEE.0 < DEFAULT_L1_BOUNDS_COMMITTED_FEE.0?

in AllResourceBounds mode, it makes sense if the L1 gas bound is very low - even zero.
so, yes

[yoavGrs]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.671 ms 34.737 ms 34.803 ms]
change: [-5.7970% -4.2970% -2.9066%] (p = 0.00 < 0.05)
Performance has improved.