Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): parametrize test_invoke_tx by resource bounds types #1321

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 11, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (e3165c4) to head (69f90e5).
Report is 95 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1321       +/-   ##
===========================================
+ Coverage   40.10%   69.13%   +29.03%     
===========================================
  Files          26      100       +74     
  Lines        1895    13447    +11552     
  Branches     1895    13447    +11552     
===========================================
+ Hits          760     9297     +8537     
- Misses       1100     3749     +2649     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from c513c51 to 4c7d6a1 Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from ae7be2c to 42d8ada Compare October 13, 2024 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 4c7d6a1 to 88806ee Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 42d8ada to 04ce114 Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 88806ee to 657a9af Compare October 13, 2024 08:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 04ce114 to 8c269eb Compare October 13, 2024 08:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 657a9af to ca28099 Compare October 13, 2024 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 8c269eb to db2167f Compare October 13, 2024 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from ca28099 to 0013a6a Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from db2167f to cc00710 Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 0013a6a to 841b9c5 Compare October 14, 2024 08:07
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from cc00710 to f5d813d Compare October 14, 2024 08:07
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 841b9c5 to 959f634 Compare October 14, 2024 09:15
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from f5d813d to d936ad2 Compare October 14, 2024 09:15
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 3d0bf82 to 83bd562 Compare October 29, 2024 10:54
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from d900be7 to aa5b31d Compare October 29, 2024 10:55
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 83bd562 to 3096d35 Compare October 29, 2024 15:30
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from aa5b31d to d4f200e Compare October 29, 2024 15:30
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from 3096d35 to 161c029 Compare October 30, 2024 11:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from d4f200e to 302d24d Compare October 30, 2024 11:37
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch 2 times, most recently from 4f52227 to e72e877 Compare October 30, 2024 12:18
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 302d24d to 3042759 Compare October 30, 2024 12:18
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds branch from e72e877 to c48181f Compare October 30, 2024 12:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 3042759 to 8a0aea2 Compare October 30, 2024 12:23
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-10-test_blockifier_update_test_revert_on_resource_overuse_to_include_new_resource_bounds to graphite-base/1321 October 30, 2024 12:58
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 8a0aea2 to 0fbf558 Compare October 30, 2024 12:58
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1321 to main October 30, 2024 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-test_blockifier_parametrize_test_invoke_tx_by_resource_bounds_types branch from 0fbf558 to 69f90e5 Compare October 30, 2024 12:59
Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 6f83204 into main Oct 31, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants