test(blockifier): update test_revert_on_resource_overuse to include new resource bounds

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• test(blockifier): migrate remaining tests to all resource bounds (except execution flavors test) #1342
• test(blockifier): parametrize more tests in transactions_test by resource bounds types #1337
• test(blockifier): parametrize test_actual_fee_gt_resource_bounds by resource bounds types #1330
• test(blockifier): parametrize test_max_fee_exceeds_balance by resource bounds types #1322
• test(blockifier): parametrize test_invoke_tx by resource bounds types #1321
• test(blockifier): update test_revert_on_resource_overuse to include new resource bounds #1314 👈
• test(blockifier): update test_insufficient_max_fee_reverts to include new resource bounds #1313
• test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312
• test(blockifier): test enforce_fee flag with new resource bounds #1311
• test(blockifier): l1 bounds -> all bounds in stack trace test #1310
• test(blockifier): l1 bounds -> all bounds in worker logic test #1309
• test(blockifier): l1 bounds -> all bounds in versioned state test #1308
• test(blockifier): add all resource bounds to stateful validator test #1307
• refactor(blockifier): refactor default testing resource bounds #1306
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• test(blockifier): update test_revert_on_resource_overuse to include new resource bounds #1314 👈
• test(blockifier): update test_insufficient_max_fee_reverts to include new resource bounds #1313
• test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312
• test(blockifier): test enforce_fee flag with new resource bounds #1311
• test(blockifier): l1 bounds -> all bounds in stack trace test #1310
• test(blockifier): l1 bounds -> all bounds in worker logic test #1309
• test(blockifier): l1 bounds -> all bounds in versioned state test #1308
• test(blockifier): add all resource bounds to stateful validator test #1307
• refactor(blockifier): refactor default testing resource bounds #1306
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (e3165c4) to head (c48181f).
Report is 84 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1314       +/-   ##
===========================================
+ Coverage   40.10%   69.15%   +29.04%     
===========================================
  Files          26      100       +74     
  Lines        1895    13447    +11552     
  Branches     1895    13447    +11552     
===========================================
+ Hits          760     9299     +8539     
- Misses       1100     3747     +2647     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[yoavGrs]

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/blockifier/feature_contracts/cairo0/test_contract.cairo line 100 at r2 (raw file):

        return ();
    }
    send_message(7);

Why do you need it?

Code quote:

send_message(7);

---

crates/blockifier/src/transaction/post_execution_test.rs line 339 at r2 (raw file):

    // reverted.
    let low_max_fee = Fee(execution_info_measure.receipt.fee.0 - 1);
    let low_bounds = if version != TransactionVersion::THREE {

For future versions.

Suggestion:

if version < TransactionVersion::THREE

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

crates/blockifier/feature_contracts/cairo0/test_contract.cairo line 100 at r2 (raw file):

Previously, yoavGrs wrote…

Why do you need it?

for the all_bounds_insufficient_l1_gas case.
we need something that costs L1 gas even when user is paying for L2 stuff with L2 gas

[github-actions]

Artifacts upload triggered. View details here

[yoavGrs]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)