fix(blockifier_reexecution): fix bug in get contract class

[AvivYossef-starkware]

No description provided.

[AvivYossef-starkware]

• build(blockifier_reexecution): add preprocess before execute txs #1821
• fix(blockifier_reexecution): bug in rpc get state diff #1797
• chore(blockifier_reexecution): add test cases #1796
• build(blockifier_reexecution): add support for l1 handler tx #1765
• fix(blockifier_reexecution): fix bug in get contract class #1759 👈
• refactor(blockifier_reexecution): compare sorted jsons instead of structs #1758
• build(blockifier_reexecution): add stability for rpc test #1712
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.77%. Comparing base (e3165c4) to head (68a18f9).
Report is 215 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   40.10%   41.77%   +1.66%     
==========================================
  Files          26      197     +171     
  Lines        1895    23304   +21409     
  Branches     1895    23304   +21409     
==========================================
+ Hits          760     9735    +8975     
- Misses       1100    13114   +12014     
- Partials       35      455     +420     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 302 at r1 (raw file):

            "class_hash": class_hash.0.to_string(),
        });
        let contract_value =

Suggestion:

raw_contract_class

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 311 at r1 (raw file):

                }
                Ok(contract) => contract,
            };

what happens if you try this? (note the ? at the end - i would expect a natural conversion from the send_rpc_request error to a variant of StateError)

Suggestion:

        let contract_value =
            match self.rpc_state_reader.send_rpc_request("starknet_getClass", params.clone()) {
                Err(RPCStateReaderError::ClassHashNotFound(_)) => {
                    return Err(StateError::UndeclaredClassHash(*class_hash));
                }
                other_result => other_result,
            }?;

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[AvivYossef-starkware]

Merge activity

• Nov 6, 7:16 AM EST: A user merged this pull request with Graphite.