-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier_reexecution): add test cases #1796
chore(blockifier_reexecution): add test cases #1796
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 40.10% 41.81% +1.70%
==========================================
Files 26 197 +171
Lines 1895 23310 +21415
Branches 1895 23310 +21415
==========================================
+ Hits 760 9747 +8987
- Misses 1100 13106 +12006
- Partials 35 457 +422 ☔ View full report in Codecov by Sentry. |
ff501b0
to
55cae6b
Compare
7ea3ad5
to
5ec6337
Compare
55cae6b
to
5c024b1
Compare
5ec6337
to
f46fb4f
Compare
5c024b1
to
55bf24c
Compare
f46fb4f
to
7c9403b
Compare
55bf24c
to
6caff94
Compare
7c9403b
to
a75a137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
a discussion (no related file):
where is the usage of these changes? cannot review unused code, need context
6caff94
to
5e03cc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
where is the usage of these changes? cannot review unused code, need context
This is an example of all the cases that interest us. I ran the RPC test command with them,
and we might use them as examples in the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
a discussion (no related file):
Previously, AvivYossef-starkware wrote…
This is an example of all the cases that interest us. I ran the RPC test command with them,
and we might use them as examples in the CI.
maybe add a block_numbers_for_reexecution
function that
- reads the JSON, one per version of starknet after and including 0.13.0
- appends the specific block numbers with extra examples
?
that way you'll only need#[allow(unused)]
once, right?
4b59672
to
87a168f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
maybe add a
block_numbers_for_reexecution
function that
- reads the JSON, one per version of starknet after and including 0.13.0
- appends the specific block numbers with extra examples
?
that way you'll only need#[allow(unused)]
once, right?
Do we want to add all possible examples for blocks with different tx types? ( total 12 blocks including the blocks per version )
87a168f
to
ca502ec
Compare
a75a137
to
887cfad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
a discussion (no related file):
Previously, AvivYossef-starkware wrote…
Do we want to add all possible examples for blocks with different tx types? ( total 12 blocks including the blocks per version )
yes
396ba95
to
a095dc1
Compare
887cfad
to
143cedd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
2efb4d5
to
5e0f94a
Compare
143cedd
to
a452353
Compare
5e0f94a
to
b18eb32
Compare
a452353
to
56aa722
Compare
e8aa6cd
to
c59fcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
yes
Done.
c59fcc9
to
368ebd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
a discussion (no related file):
Previously, AvivYossef-starkware wrote…
Done.
can you delete the constants with the special block numbers? if not, why are they still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
can you delete the constants with the special block numbers? if not, why are they still needed?
We use them in the test file, I can fetch the JSON and extract them instead of using constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
a discussion (no related file):
Previously, AvivYossef-starkware wrote…
We use them in the test file, I can fetch the JSON and extract them instead of using constants
can be in a separate PR... maybe we want something smarter, that can also be used to parametrize Aner's offline test
Merge activity
|
No description provided.