build(blockifier_reexecution): add support for l1 handler tx

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• build(blockifier_reexecution): add preprocess before execute txs #1821
• fix(blockifier_reexecution): bug in rpc get state diff #1797
• chore(blockifier_reexecution): add test cases #1796
• build(blockifier_reexecution): add support for l1 handler tx #1765 👈
• fix(blockifier_reexecution): fix bug in get contract class #1759
• refactor(blockifier_reexecution): compare sorted jsons instead of structs #1758
• build(blockifier_reexecution): add stability for rpc test #1712
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 41.76%. Comparing base (e3165c4) to head (5e0f94a).
Report is 217 commits behind head on main.

Files with missing lines	Patch %	Lines
...ution/src/state_reader/reexecution_state_reader.rs	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
+ Coverage   40.10%   41.76%   +1.66%     
==========================================
  Files          26      197     +171     
  Lines        1895    23309   +21414     
  Branches     1895    23309   +21414     
==========================================
+ Hits          760     9736    +8976     
- Misses       1100    13116   +12016     
- Partials       35      457     +422     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 45 at r1 (raw file):

                Transaction::Invoke(_) | Transaction::DeployAccount(_) => {
                    BlockifierTransaction::from_api(tx, tx_hash, None, None, None, false)
                        .map_err(ReexecutionError::from)

do you really need these?
why not replace with ??

times 3

Code quote:

.map_err(ReexecutionError::from)

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 68 at r1 (raw file):

                        tx_hash,
                        None,
                        Some(Fee(u128::MAX)),

there is a constant MAX_FEE in the blockifier, isn't it public?

Suggestion:

Some(Fee(MAX_FEE))

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)

[AvivYossef-starkware]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 45 at r1 (raw file):

Previously, dorimedini-starkware wrote…

do you really need these?
why not replace with ??

times 3

it works

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 68 at r1 (raw file):

Previously, dorimedini-starkware wrote…

there is a constant MAX_FEE in the blockifier, isn't it public?

Are you sure? I don't find it

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 68 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

Are you sure? I don't find it

here

[AvivYossef-starkware]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)

---

crates/blockifier_reexecution/src/state_reader/reexecution_state_reader.rs line 68 at r1 (raw file):

Previously, dorimedini-starkware wrote…

here

Thanks

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[dorimedini-starkware]

Reviewed 4 of 4 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

[AvivYossef-starkware]

Merge activity

• Nov 6, 7:31 AM EST: A user merged this pull request with Graphite.