Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batcher): extract the deadline function in order to share with the validate flow #2049

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.04%. Comparing base (e3165c4) to head (5207191).
Report is 470 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher/src/batcher.rs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2049       +/-   ##
==========================================
- Coverage   40.10%   5.04%   -35.07%     
==========================================
  Files          26     144      +118     
  Lines        1895   17021    +15126     
  Branches     1895   17021    +15126     
==========================================
+ Hits          760     858       +98     
- Misses       1100   16091    +14991     
- Partials       35      72       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@Yael-Starkware Yael-Starkware force-pushed the yael/add_batcher_config branch 3 times, most recently from 4115cb5 to 78a5182 Compare November 17, 2024 07:20
@Yael-Starkware Yael-Starkware force-pushed the yael/compute_deadline_function branch from fcc9649 to 6167a5f Compare November 17, 2024 07:20
@Yael-Starkware Yael-Starkware force-pushed the yael/add_batcher_config branch from 78a5182 to 1c2a5f7 Compare November 17, 2024 07:41
@Yael-Starkware Yael-Starkware force-pushed the yael/compute_deadline_function branch from 6167a5f to d751651 Compare November 17, 2024 07:42
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

Copy link
Contributor Author

Yael-Starkware commented Nov 18, 2024

Merge activity

  • Nov 18, 7:49 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 18, 7:51 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 18, 8:12 AM EST: A user merged this pull request with Graphite.

@Yael-Starkware Yael-Starkware changed the base branch from yael/add_batcher_config to graphite-base/2049 November 18, 2024 12:49
@Yael-Starkware Yael-Starkware changed the base branch from graphite-base/2049 to main November 18, 2024 12:49
@Yael-Starkware Yael-Starkware force-pushed the yael/compute_deadline_function branch from d751651 to 5207191 Compare November 18, 2024 12:50
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants