chore(batcher): rename build_proposal => propose_block and validate_proposal => validate_block

[Yael-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

• chore(batcher): rename build_proposal => propose_block and validate_proposal => validate_block #2162 👈 (View in Graphite)
• fix(batcher): fix send_proposal_content return status and add the relevant tests #2053 : 2 other dependent PRs (#2126 , #2148 )
• feat(batcher): add validate flow #2050
• refactor(batcher): extract the deadline function in order to share with the validate flow #2049
• refactor(batcher): add input channel size config #2042
• refactor(batcher): add batcher creation func to test #2046
• feat(batcher): add validate flow to proposal manager #1951
• refactor(batcher): add propose_tx_provider fixture #1996
• refactor(batcher): change BuildProposalError to GenerateProposalError #1986
• refactor(batcher): extract common logic into a function for validate flow #1985
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alonh5]

Is this all the locations we want to change? What about the generate error?

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_batcher/src/batcher.rs line 60 at r1 (raw file):

    proposal_manager: Box<dyn ProposalManagerTrait>,
    propose_streams: HashMap<ProposalId, OutputStreamReceiver>,
    validate_streams: HashMap<ProposalId, InputStreamSender>,

Suggestion:

    propose_tx_streams: HashMap<ProposalId, OutputStreamReceiver>,
    validate_tx_streams: HashMap<ProposalId, InputStreamSender>,

[codecov]

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 12.92%. Comparing base (e3165c4) to head (564faf2).
Report is 494 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_batcher_types/src/communication.rs	0.00%	6 Missing ⚠️
crates/starknet_batcher/src/communication.rs	0.00%	4 Missing ⚠️
...us_orchestrator/src/sequencer_consensus_context.rs	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2162       +/-   ##
===========================================
- Coverage   40.10%   12.92%   -27.19%     
===========================================
  Files          26      188      +162     
  Lines        1895    24020    +22125     
  Branches     1895    24020    +22125     
===========================================
+ Hits          760     3104     +2344     
- Misses       1100    20560    +19460     
- Partials       35      356      +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[Yael-Starkware]

these are all the locations as far as I could think of/search for.
I think GenerateProposalError name is ok.

Reviewable status: 6 of 9 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_batcher/src/batcher.rs line 60 at r1 (raw file):

    proposal_manager: Box<dyn ProposalManagerTrait>,
    propose_streams: HashMap<ProposalId, OutputStreamReceiver>,
    validate_streams: HashMap<ProposalId, InputStreamSender>,

done.

[alonh5]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)