chore(starknet_api): move gas price related test consts to starknet api #2443
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
+ Coverage 40.10% 49.63% +9.52%
==========================================
Files 26 311 +285
Lines 1895 35370 +33475
Branches 1895 35370 +33475
==========================================
+ Hits 760 17555 +16795
- Misses 1100 16613 +15513
- Partials 35 1202 +1167 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/test_utils/gas_prices/move_consts_to_snapi
branch
from
f1030a1 to
4760d79
Compare
There was a problem hiding this comment.
Reviewed 2 of 15 files at r1, 13 of 13 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/starknet_api/src/test_utils.rs line 119 at r2 (raw file):
// The max_fee / resource bounds used for txs in this test. // V3 transactions:
Is this comment still relevant?
Same below
Code quote:
// The max_fee / resource bounds used for txs in this test.
// V3 transactions:
ArniStarkware
force-pushed
the
arni/test_utils/gas_prices/move_consts_to_snapi
branch
4 times, most recently
from
dfca6ec to
5506889
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 2 of 15 files at r1, 13 of 13 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/starknet_api/src/test_utils.rs line 119 at r2 (raw file):
// The max_fee / resource bounds used for txs in this test. // V3 transactions:
Fix comment
Code quote:
// The max_fee / resource bounds used for txs in this test.
// V3 transactions:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
ArniStarkware
force-pushed
the
arni/test_utils/gas_prices/move_consts_to_snapi
branch
from
5506889 to
3c92529
Compare
There was a problem hiding this comment.
Reviewable status: 12 of 15 files reviewed, all discussions resolved (waiting on @alonh5)
crates/starknet_api/src/test_utils.rs line 119 at r2 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Fix comment
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alonh5)
No description provided.