test(starknet_batcher): setup gas prices for testing

[ArniStarkware]

No description provided.

[ArniStarkware]

• chore(starknet_api): use const fn create for testing block info #2561
• chore(starknet_api): move test utils constants to starknet api #2446
• test(starknet_batcher): setup gas prices for testing #2445 👈 (View in Graphite)
• chore(starknet_api): move gas price related test consts to starknet api #2443 : 1 other dependent PR (#2444 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-04T09:57:21Z
• Started at 2024-12-04T10:02:41Z
• Started at 2024-12-04T10:03:47Z
• Started at 2024-12-04T10:08:50Z
• Started at 2024-12-09T09:42:36Z
• Started at 2024-12-16T15:49:50Z
• Started at 2024-12-16T18:31:56Z
• Started at 2024-12-16T18:52:44Z
• Started at 2024-12-17T07:56:03Z
• Started at 2024-12-17T11:57:20Z

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_api/src/block.rs line 456 at r1 (raw file):

// TODO(Arni): Remove derive of Default. Gas prices should always be set.
#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]

I used this to compare the results. There is no need for this struct to implement these properties.

Suggestion:

#[derive(Clone, Debug, Default, Deserialize, Serialize)]

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_api/src/block.rs line 456 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

I used this to compare the results. There is no need for this struct to implement these properties.

Done.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (arni/gas_prices/fix_default_strk_l1_gas_price@71ef06d). Learn more about missing BASE report.

Additional details and impacted files

@@                               Coverage Diff                                @@
##             arni/gas_prices/fix_default_strk_l1_gas_price    #2445   +/-   ##
================================================================================
  Coverage                                                 ?   80.02%           
================================================================================
  Files                                                    ?       98           
  Lines                                                    ?    13596           
  Branches                                                 ?    13596           
================================================================================
  Hits                                                     ?    10880           
  Misses                                                   ?     2232           
  Partials                                                 ?      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alonh5]

Reviewed 1 of 4 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/starknet_api/src/test_utils.rs line 138 at r3 (raw file):

    NonzeroGasPrice::new_unchecked(GasPrice(25 * u128::pow(10, 5)));
pub const DEFAULT_STRK_L2_GAS_PRICE: NonzeroGasPrice =
    NonzeroGasPrice::new_unchecked(GasPrice(25 * u128::pow(10, 5)));

This is a good place to use static lazy if you want them to match the default l1 price.

Code quote:

pub const DEFAULT_ETH_L2_GAS_PRICE: NonzeroGasPrice =
    NonzeroGasPrice::new_unchecked(GasPrice(25 * u128::pow(10, 5)));
pub const DEFAULT_STRK_L2_GAS_PRICE: NonzeroGasPrice =
    NonzeroGasPrice::new_unchecked(GasPrice(25 * u128::pow(10, 5)));

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.746 ms 29.794 ms 29.849 ms]
change: [-2.2122% -1.9862% -1.7662%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.132 ms 30.193 ms 30.255 ms]
change: [+1.1434% +1.3841% +1.6358%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

[ArniStarkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_api/src/test_utils.rs line 138 at r3 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

This is a good place to use static lazy if you want them to match the default l1 price.

1. There is no need to match them to the l1 gas price.
2. The mechanism that does the conversion is dependent on versioned constants, which are in the blockifier repo.
3. If we put DEFAULT_ETH_L2_GAS_PRICE and DEFAULT_STRK_L2_GAS_PRICE inside a lazy evaluation block of any type, we would have to do the same for DEFAULT_GAS_PRICES. As I said in item 1 of this list - there is no benefit to that.

[alonh5]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Merge activity

• Dec 18, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 18, 7:09 AM EST: A user merged this pull request with Graphite.