chore(starknet_api): use const fn create for testing block info

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(starknet_api): use const fn create for testing block info #2561 👈 (View in Graphite)
• chore(starknet_api): move test utils constants to starknet api #2446
• test(starknet_batcher): setup gas prices for testing #2445
• chore(starknet_api): move gas price related test consts to starknet api #2443 : 1 other dependent PR (#2444 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (arni/test_utils/move_to_snapi@763ff23). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/core.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                        @@
##             arni/test_utils/move_to_snapi    #2561   +/-   ##
================================================================
  Coverage                                 ?   47.40%           
================================================================
  Files                                    ?       29           
  Lines                                    ?     2909           
  Branches                                 ?     2909           
================================================================
  Hits                                     ?     1379           
  Misses                                   ?     1464           
  Partials                                 ?       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alonh5]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/starknet_api/src/test_utils.rs line 180 at r1 (raw file):

impl BlockInfo {
    pub const fn create_for_testing() -> Self {

Why do we need this to be const?

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.742 ms 35.246 ms 35.838 ms]
change: [+1.2127% +2.6176% +4.5409%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) high severe

[ArniStarkware]

No need for this PR.