Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMake built-in dir create function instead of hard-coded mkdir #108

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Use CMake built-in dir create function instead of hard-coded mkdir #108

merged 1 commit into from
Sep 3, 2024

Conversation

mortbopet
Copy link
Contributor

... Because all systems may not play nice with mkdir -p.

@mortbopet
Use CMake built-in dir create function instead of hard-coded mkdir
6b187d2 
... Because all systems may not play nice with `mkdir -p`.
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mortbopet pushed a commit to mortbopet/substrait-cpp that referenced this pull request Sep 3, 2024
Minimum viable changes for Windows build
8d5da6b 
This + PRs substrait-io#109 and substrait-io#108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.
@mortbopet mortbopet mentioned this pull request Sep 3, 2024
Merged
EpsilonPrime
EpsilonPrime approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely more portable.

@EpsilonPrime EpsilonPrime merged commit ef33fd8 into substrait-io:main Sep 3, 2024
3 checks passed
mortbopet pushed a commit to mortbopet/substrait-cpp that referenced this pull request Sep 4, 2024
@mortbopet
Minimum viable changes for Windows build
34e3f28 
This + PRs substrait-io#109 and substrait-io#108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.
EpsilonPrime pushed a commit that referenced this pull request Sep 4, 2024
@mortbopet
Minimum viable changes for Windows build (#110)
8c8350c 
This + PRs #109 and
#108 should be
sufficient for a minimum-viable Windows (MSVC) build of this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mortbopet @CLAassistant @EpsilonPrime