Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard for georeference in BSM generator #2403

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Jun 11, 2024

PR Details

Description

This PR attempts to fix valid lat/lon generation failure in BSM generator which leads to BSM encoding failure.
Tested on Black Pacifica and I didn't see any BSM errors for 5+ runs where I was seeing almost every run.

Related GitHub Issue

#2402

Related Jira Key

https://usdot-carma.atlassian.net/browse/CAR-6059

Motivation and Context

Seen it simulation as well as live vehicle.
Distributed Testing (VOICES) relies on vehicle's valid BSM, so encountered this issue.

How Has This Been Tested?

Tested on Black Pacifica and I didn't see any BSM errors for 5+ runs where I was seeing almost every run.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from JonSmet June 11, 2024 00:02
@MishkaMN MishkaMN self-assigned this Jun 11, 2024
@MishkaMN MishkaMN added the anomaly Something isn't working label Jun 11, 2024
@MishkaMN MishkaMN mentioned this pull request Jun 11, 2024
9 tasks
Copy link
Contributor

@JonSmet JonSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the failed unit test is related to rosbag2_tests; approving since this is not a package that we maintain, so we will look into disabling its tests as a part of CI in a future PR.

2024-06-14T19:18:43.6481672Z  1/11 Test  #1: test_rosbag2_record_end_to_end ...***Timeout  60.05 sec

@MishkaMN MishkaMN merged commit 9913963 into develop Jun 14, 2024
2 of 3 checks passed
@MishkaMN MishkaMN deleted the car-6059-bsm-generator-failure branch June 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants