Update docker-compose version of AWS instance #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adev4a
reviewed
Jul 30, 2024
| @@ -32,6 +32,10 @@ Parameters: | |||
| Description: The specific carma config which launches xil and platform to make available in the instance | |||
| Type: String | |||
| Default: "usdotfhwastoldev/carma-config:xil-cloud-test" | |||
| DockerComposeVersion: | |||
There was a problem hiding this comment.
Looks like this doesn't need to be argument for the yaml. Local scope on line 429-430 should be enough
There was a problem hiding this comment.
Yeah weird syntax error was giving me trouble so I was trying out different approaches. I learned in this aws yaml context that:
- ${VARIABLE} is a parameter defined in the yaml level
- $VARIABLE is a variable for the shell.
Although I did defined the VARIABLE=docker-compose-version, it kept giving me error when I used it as ${VARIABLE} saying it was not resolved.
|
adev4a
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Updating docker-compose used in the AWS instance.
Previous one is outdated due to carma script update.
Related GitHub Issue
NA
Related Jira Key
ARC-133
https://usdot-carma.atlassian.net/browse/ARC-133
Motivation and Context
Triggered by this change #2409
How Has This Been Tested?
Tested by launching AWS instance and checking version of docker-compose and carma script contents:
Types of changes
Checklist: