Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: External Link (in Action Block) #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbmoelker
Copy link
Member

Changes

  • Adds ExternalLink item to ActionBlock with required title and url field (with validation).
  • Matches the openInNewTab property also available in the built-in links in StructuredText fields.
  • Reuses the same style field configuration used for the InternalLink block.

Associated issue

N/A

How to test

  1. Open preview link
  2. Navigate to the Action Block demo and scroll down to the "Action block with External Links" section.
  3. Verify the External Links render as primary and secondary
  4. Verify the first action opens the external link in the same tab, and the second action opens a new tab
  5. Go the the external-links environment and play around with the new External Link option in Action Blocks
  6. Verify changes made are reflected in the web page (note: run locally as changes are not updated on deploy preview)

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

@jbmoelker jbmoelker changed the title feature: ExternalLink (in ActionBlock) feature: External Link (in Action Block) Dec 28, 2024
@jbmoelker jbmoelker mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant