fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages.

[sergeyberezansky]

TL;DR

Updated image pull secret configuration for CSI WekaFS plugin

What changed?

• Modified controllerserver-serviceaccount.yaml and nodeserver-serviceaccount.yaml to use a configurable image pull secret
• Added imagePullSecret parameter in values.yaml to specify the name of the image pull secret
• Wrapped image pull secret configuration in conditional statements to only apply when specified

How to test?

1. Deploy the chart with imagePullSecret set to an existing secret name
2. Verify that the controller and node service accounts are created with the specified image pull secret
3. Deploy the chart without setting imagePullSecret
4. Confirm that no image pull secret is added to the service accounts

Why make this change?

This change allows users to specify a custom image pull secret for private registries that require authentication. It provides more flexibility in deployment scenarios where images are stored in private repositories, while maintaining backwards compatibility for deployments that don't require image pull secrets.

In most cases, since CSI plugin components reside in public repository, this will help to avoid "Could not fetch some secrets" errors in Kubernetes

---

[sergeyberezansky]

• chore(deps): update sidecar versions #326
• docs(CSI-254): update official docs link in Helm templates and README #323
• feat(CSI-252): implement kubelet PVC stats #322
• refactor(CSI-250): do not maintain redundant active mounts from node server after publishing volume #320
• feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress() #319
• feat(CSI-249): optimize NFS mounter to use multiple targets #318
• fix(CSI-241): fix unmountWithOptions to use map key rather than options.String() #317
• feat(CSI-245): allow specifying client group for NFS #316
• chore(deps): update packages to latest versions and Go to 1.22.5 #314
• chore(deps): combine chmod with ADD in Dockerfile #313
• feat(CSI-239): moveToTrash does not return error to upper layers #312
• fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages. #311 👈
• feat(CSI-244): match subnets if existing in client rule #315
• fix(CSI-241): conflict in metrics between node and controller #325
• feat(CSI-213): support NFS transport #299
• fix(CSI-241): disregard sync_on_close in mountmap per FS #310
• feat(CSI-253): support custom CA certificate in API secret #324
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/02/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 7:07 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 7:09 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 7:14 AM EDT: @sergeyberezansky merged this pull request with Graphite.