feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress()

[sergeyberezansky]

TL;DR

Implemented random IP selection for NFS mounts and simplified mount reference counting.

What changed?

• Added a new GetRandomIpAddress method to the InterfaceGroup struct, which selects a random IP address from the available IPs.
• Modified GetNfsMountIp to use the new GetRandomIpAddress method instead of GetIpAddress.
• Removed reference counting logic from the nfsMount struct, including the refCount field and associated lock.
• Simplified incRef and decRef methods to always perform mount and unmount operations, respectively.

How to test?

1. Test the new GetRandomIpAddress method by calling it multiple times and verifying that different IPs are returned.
2. Verify that NFS mounts now use randomly selected IP addresses.
3. Test mounting and unmounting operations to ensure they work correctly without reference counting.
4. Check that concurrent mount operations are handled properly.

Why make this change?

• Random IP selection for NFS mounts improves load balancing across available IPs.
• Simplifying the mount reference counting reduces complexity and potential race conditions.
• These changes aim to enhance the reliability and performance of NFS mount operations in the system.

---

feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress()

feat(CSI-247): optimize NFS by utilizing multiple targets

[sergeyberezansky]

• chore(deps): update sidecar versions #326
• docs(CSI-254): update official docs link in Helm templates and README #323
• feat(CSI-252): implement kubelet PVC stats #322
• refactor(CSI-250): do not maintain redundant active mounts from node server after publishing volume #320
• feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress() #319 👈
• feat(CSI-249): optimize NFS mounter to use multiple targets #318
• fix(CSI-241): fix unmountWithOptions to use map key rather than options.String() #317
• feat(CSI-245): allow specifying client group for NFS #316
• chore(deps): update packages to latest versions and Go to 1.22.5 #314
• chore(deps): combine chmod with ADD in Dockerfile #313
• feat(CSI-239): moveToTrash does not return error to upper layers #312
• fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages. #311
• feat(CSI-244): match subnets if existing in client rule #315
• fix(CSI-241): conflict in metrics between node and controller #325
• feat(CSI-213): support NFS transport #299
• fix(CSI-241): disregard sync_on_close in mountmap per FS #310
• feat(CSI-253): support custom CA certificate in API secret #324
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/05/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 7:43 AM EDT: Graphite couldn't merge this pull request because a downstack PR feat(CSI-245): allow specifying client group for NFS #316 failed to merge.
• Sep 12, 8:43 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 8:45 AM EDT: The Graphite merge of this pull request was cancelled.