Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-241): conflict in metrics between node and controller #325

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Sep 11, 2024

TL;DR

Updated metrics configuration for CSI WekaFS Plugin to support separate ports for different components.

What changed?

  • Modified the prometheus.io/port annotation in controllerserver-statefulset.yaml to include separate ports for controller, provisioner, resizer, and snapshotter.
  • Updated the metrics port configuration in both controllerserver-statefulset.yaml and nodeserver-daemonset.yaml to use component-specific ports.
  • Added new metrics port configurations in values.yaml:
    • controllerPort: 9090
    • provisionerPort: 9091
    • resizerPort: 9092
    • snapshotterPort: 9093
    • nodePort: 9094

How to test?

  1. Deploy the CSI WekaFS Plugin with metrics enabled.
  2. Verify that the prometheus.io/port annotation in the controller pod includes all specified ports.
  3. Check that the controller and node server pods are exposing metrics on their respective ports.
  4. Attempt to scrape metrics from each component using the newly configured ports.

Why make this change?

This change allows for more granular control over metrics collection for different components of the CSI WekaFS Plugin. By using separate ports for each component, it becomes easier to monitor and troubleshoot specific parts of the plugin, enhancing observability and debugging capabilities.

Additional idea behind this change is avoiding port conflicts when running CSI plugin in hostNetwork mode (required for NFS)


Copy link

graphite-app bot commented Sep 11, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/11/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

sergeyberezansky commented Sep 12, 2024

Merge activity

  • Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
  • Sep 12, 6:36 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 6:39 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 6:54 AM EDT: @sergeyberezansky merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/nfs_support to graphite-base/325 September 12, 2024 10:26
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/325 to dev September 12, 2024 10:34
@sergeyberezansky sergeyberezansky merged commit 6710087 into dev Sep 12, 2024
11 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/modify-default-hostports branch September 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant