Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: sensor: add wurth elektronik sensor drivers #62408

Closed
wants to merge 14 commits into from
Closed

drivers: sensor: add wurth elektronik sensor drivers #62408

wants to merge 14 commits into from

Conversation

wm-eisos
Copy link
Contributor

@wm-eisos wm-eisos commented Sep 7, 2023

This pull request updates the revision of the hal, removes old drivers and updates and adds new drivers.

@mah-eiSmart

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 7, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_wurthelektronik zephyrproject-rtos/hal_wurthelektronik@e5bcb2e zephyrproject-rtos/hal_wurthelektronik@e3e2797 (zephyr) zephyrproject-rtos/hal_wurthelektronik@e5bcb2ea..e3e2797b

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@wm-eisos wm-eisos force-pushed the wurth_drivers branch 2 times, most recently from 610cb7f to 4ecf6ca Compare September 7, 2023 15:15
@wm-eisos wm-eisos changed the title Update and add new wurth elektronik sensor drivers drivers: sensor: add wurth elektronik sensor drivers Sep 7, 2023
@wm-eisos wm-eisos force-pushed the wurth_drivers branch 5 times, most recently from 1c7ac90 to 38823eb Compare September 8, 2023 11:47
@mah-eiSmart
Copy link
Contributor

This is a big improvement to the Würth Elektronik sensor drivers, as

  • the sensor names are correct now (the name without article number does not identify the sensor)
  • numerous useful functions have been added
  • examples are added how to use the custom attributes
  • it's using the newest würth elektronik hal with the latest bug fixes

Thank you for contributing @wm-eisos and for reviewing.

BTW: The examples and drivers have been tested on several hardware platforms.

@wm-eisos wm-eisos marked this pull request as ready for review September 8, 2023 12:29
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Sep 8, 2023
yperess
yperess previously approved these changes Sep 8, 2023
View reviewed changes
@yperess
Copy link
Collaborator

yperess commented Sep 8, 2023

The change looks fine (I wanted to add the approval so I can revisit the diff when the docs/compliance checks pass). @wm-eisos please address the failing checks and I'll be happy to re-approve.

@wm-eisos wm-eisos marked this pull request as draft September 11, 2023 07:01
@wm-eisos wm-eisos marked this pull request as ready for review September 11, 2023 12:41
@wm-eisos
drivers: sensor: wsen_hids: remove wsen_hids driver
d087179 
Remove wsen_hids since the hal update
is no longer compatible with this version.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_pads: remove wsen_pads driver
51b281d 
Remove wsen_pads since the hal update
is no longer compatible with this version.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_pdus: remove wsen_pdus driver
e50f23d 
Remove wsen_pdus since the hal update
is no longer compatible with this version.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_tids: remove wsen_tids driver
6085fbd 
Remove wsen_tids since the hal update
is no longer compatible with this version.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
manifest: hal_wurthelektronik: update to latest
2d4ed3f 
Update hal_wurthelektronik to include latest sensor core drivers.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_hids_2525020210002: add sensor driver
00887bb 
Add wsen_hids_2525020210002 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_pdus_25131308XXXXX: add sensor driver
67a3160 
Add wsen_pdus_25131308XXXXX driver with
the corrected name and compatibility with
the hal update as well as added new features..

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_tids_2521020222501: add sensor driver
059d193 
Add wsen_tids_2521020222501 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@decsny
Copy link
Member

decsny commented Aug 20, 2024

there is a merge conflict

I will solve it now however as you can see in this PR this loop keeps hapening where the merge conflicts are resolved and then new merge conflicts come up because the PR is still not merged

welcome to my life as well

@decsny
Copy link
Member

decsny commented Aug 20, 2024

@mah-eiSmart it looks like you approved of this PR, is that still the case

@mah-eiSmart
Copy link
Contributor

mah-eiSmart commented Aug 21, 2024 •
edited
Loading

@mah-eiSmart it looks like you approved of this PR, is that still the case

Yes, from my side it's still fine.
BTW: Thank you for reviewing!

@wm-eisos
drivers: sensor: wsen_hids_2525020210001: add sensor driver
0967e37 
Add wsen_hids_2525020210001 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_pads_2511020213301: add sensor driver
41620c0 
Add wsen_pads_2511020213301 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_itds_2533020201601: add sensor driver
9b847bb 
Add wsen_itds_2533020201601 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
drivers: sensor: wsen_isds_2536030320001: add sensor driver
95a4944 
Add wsen_isds_2536030320001 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos
doc: releases: update notes for wurth drivers update
4c5ff00 
update release notes and migration guide for
wurth elektronik sensor drivers update.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos wm-eisos requested a review from decsny August 23, 2024 13:56
decsny
decsny approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somebody with sensor knowledge should review

@dkalowsk
Copy link
Contributor

somebody with sensor knowledge should review

@MaureenHelm as sensor maintainer, are you able to take a review of this?

@mah-eiSmart
Copy link
Contributor

somebody with sensor knowledge should review

@MaureenHelm as sensor maintainer, are you able to take a review of this?

@dkalowsk Seems, @MaureenHelm is busy. Can we go forward without her help?

@dkalowsk
Copy link
Contributor

somebody with sensor knowledge should review

@MaureenHelm as sensor maintainer, are you able to take a review of this?

@dkalowsk Seems, @MaureenHelm is busy. Can we go forward without her help?

There are ways to do so. You can escalate in the developer meeting or on discord. I’m a little more concerned that this PR is a year in the making and stalling out on reviews. @nashif @MaureenHelm ping.

@mah-eiSmart
Copy link
Contributor

somebody with sensor knowledge should review

@MaureenHelm as sensor maintainer, are you able to take a review of this?

@dkalowsk Seems, @MaureenHelm is busy. Can we go forward without her help?

There are ways to do so. You can escalate in the developer meeting or on discord. I’m a little more concerned that this PR is a year in the making and stalling out on reviews. @nashif @MaureenHelm ping.

@dkalowsk , this PR has been adopted to new versions of Zephyr many times, in the past 12 months. Thus it's still up to date. Yesterday I got feedback that customers did not choose that sensor products, because the drivers are not up to date. Escalating on discord or on developer meeting we did not do so far, we have no experience with it.

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Oct 9, 2024

This PR will be closed as the plan is to have seperate PRs per sensor

@wm-eisos wm-eisos closed this Oct 9, 2024
@wm-eisos wm-eisos mentioned this pull request Oct 9, 2024
Merged
@decsny decsny mentioned this pull request Oct 15, 2024
Draft
@wm-eisos wm-eisos mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decsny decsny decsny approved these changes

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@avisconti avisconti Awaiting requested review from avisconti

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@kartben kartben Awaiting requested review from kartben

@yperess yperess Awaiting requested review from yperess

@aescolar aescolar Awaiting requested review from aescolar

@ubieda ubieda Awaiting requested review from ubieda

@dkalowsk dkalowsk Awaiting requested review from dkalowsk

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

Assignees

@MaureenHelm MaureenHelm

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples area: Sensors Sensors manifest manifest-hal_wurthelektronik Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@wm-eisos @zephyrbot @mah-eiSmart @yperess @kartben @MaureenHelm @aescolar @decsny @dkalowsk @fabiobaltieri