Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: i3c: cadence: fix tx_fifo width for target mode on rev_id 1p7 #78520

Conversation

naveeng1001
Copy link
Contributor

Cadence I3C target FIFO width has been increased to 4 bytes in i3c hardware rev_id 1p7. Writing 1 byte to 4 byte FIFOs can cause unintentional padding for bytes written from TX threshold interrupt handler. Fixed the target callback to handle tx width of i3c target writes to FIFO, by using run time rev_id check.

Copy link

Hello @naveeng1001, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@naveeng1001 naveeng1001 force-pushed the fix_cadence_i3c_slv_rev_1p7_tx_fifo_size branch 2 times, most recently from 2144341 to f966e4f Compare September 17, 2024 02:19
drivers/i3c/i3c_cdns.c Outdated Show resolved Hide resolved
drivers/i3c/i3c_cdns.c Outdated Show resolved Hide resolved
@naveeng1001 naveeng1001 force-pushed the fix_cadence_i3c_slv_rev_1p7_tx_fifo_size branch from 03cb24c to 0a1bc90 Compare September 18, 2024 22:32
Cadence I3C target FIFO width has been increased to 4 bytes in i3c
hardware REV_ID 1.7. Writing 1 byte to 4 byte FIFOs can cause
unintentional padding for bytes written from TX threshold interrupt
handler. Fixed the target callback to handle tx width of i3c target
writes to FIFO, by using run time rev_id check.

Signed-off-by: Naveen Gangadharan <naveeng1001@meta.com>
@carlescufi carlescufi merged commit 27d5528 into zephyrproject-rtos:main Sep 23, 2024
23 checks passed
Copy link

Hi @naveeng1001!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@naveeng1001 naveeng1001 deleted the fix_cadence_i3c_slv_rev_1p7_tx_fifo_size branch September 24, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants