Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force and velocity hardware interfaces #44

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

pac48
Copy link
Collaborator

@pac48 pac48 commented Jan 30, 2024

This PR adds ros2_control command interfaces to configure the gripper velocity and max effort. The plan is to deprecate the current gripper controller and replace it with a new one that supports position, velocity, and effort commands.

Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
@pac48 pac48 force-pushed the pr-add-params-for-velocity-force branch from 2f7e150 to 3c3b70c Compare January 30, 2024 22:22
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
@pac48 pac48 force-pushed the pr-add-params-for-velocity-force branch from 3c3b70c to cea992f Compare January 30, 2024 23:54
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
@pac48 pac48 self-assigned this Feb 2, 2024
@moriarty
Copy link
Contributor

moriarty commented Feb 8, 2024

This PR #45 will fix the coverage build error.

@pac48 pac48 marked this pull request as ready for review February 9, 2024 23:01
sea-bass
sea-bass previously approved these changes Feb 14, 2024
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 434 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (79d0303) 20.29%.
Report is 15 commits behind head on main.

Files Patch % Lines
robotiq_driver/src/default_driver.cpp 9.09% 120 Missing ⚠️
robotiq_driver/src/hardware_interface.cpp 10.28% 70 Missing and 26 partials ⚠️
robotiq_driver/src/fake/fake_driver.cpp 0.00% 35 Missing ⚠️
robotiq_driver/src/default_serial.cpp 22.72% 32 Missing and 2 partials ⚠️
...botiq_driver/tests/test_default_driver_factory.cpp 34.28% 0 Missing and 23 partials ⚠️
robotiq_driver/src/default_driver_factory.cpp 26.66% 3 Missing and 19 partials ⚠️
robotiq_driver/src/default_serial_factory.cpp 29.16% 0 Missing and 17 partials ⚠️
..._controllers/src/robotiq_activation_controller.cpp 0.00% 15 Missing ⚠️
robotiq_driver/src/data_utils.cpp 55.88% 3 Missing and 12 partials ⚠️
...botiq_driver/tests/test_default_serial_factory.cpp 44.44% 0 Missing and 15 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #44       +/-   ##
==========================================
+ Coverage   0.00%   20.29%   +20.29%     
==========================================
  Files          5       20       +15     
  Lines        352      611      +259     
  Branches       0      250      +250     
==========================================
+ Hits           0      124      +124     
+ Misses       352      347        -5     
- Partials       0      140      +140     
Flag Coverage Δ
unittests 20.29% <20.80%> (+20.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moriarty moriarty merged commit d739382 into main Feb 15, 2024
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pr-add-params-for-velocity-force branch February 15, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants