-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mimic tags and rename sim_ignition
to sim_gazebo
#54
Conversation
sim_ignition
to sim_gazebo
sim_ignition
to sim_gazebo
It does seem like ros2_control has thrown yet another curveball at us here... I'll take a look later if I can will myself to |
Damn, thanks! |
This is the PR that broke things -- fixing now Of course, this means that non-rolling CI will now fail, so CI stuff will need to be modified to be on different branches, etc. I recommend that someone with admin power branch out |
acf116c
to
7b4de49
Compare
7b4de49
to
2a735e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 0.00% 40.26% +40.26%
==========================================
Files 5 20 +15
Lines 352 524 +172
Branches 0 33 +33
==========================================
+ Hits 0 211 +211
+ Misses 352 308 -44
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you @sea-bass ! |
I was trying to use this package on Rolling / Ubuntu 24.04 and ran into this problem.
Found it was related to ros-controls/ros2_control#1553, in which the
<mimic>
tags have been deprecated as this information is now looked up directly from URDF.So these tags, and command interfaces, for mimic joints, should be removed.
BTW: This fixes Rolling CI because of a unit test that broke due to the above changes
... though the Coverage build seems to be failing for another reason. Seems to be ros-tooling/action-ros-ci#844
EDIT: fixed in #56
I also took the liberty of renaming
sim_ignition
tosim_gazebo
in accordance to my related PR to the Kortex repo: Kinovarobotics/ros2_kortex#228. But I can concede and pull that out to a future PR.