Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mimic tags and rename sim_ignition to sim_gazebo #54

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jul 5, 2024

I was trying to use this package on Rolling / Ubuntu 24.04 and ran into this problem.

Found it was related to ros-controls/ros2_control#1553, in which the <mimic> tags have been deprecated as this information is now looked up directly from URDF.

So these tags, and command interfaces, for mimic joints, should be removed.


BTW: This fixes Rolling CI because of a unit test that broke due to the above changes

... though the Coverage build seems to be failing for another reason. Seems to be ros-tooling/action-ros-ci#844

EDIT: fixed in #56


I also took the liberty of renaming sim_ignition to sim_gazebo in accordance to my related PR to the Kortex repo: Kinovarobotics/ros2_kortex#228. But I can concede and pull that out to a future PR.

@sea-bass sea-bass changed the title Remove mimic tags and renamesim_ignition to sim_gazebo Remove mimic tags and rename sim_ignition to sim_gazebo Jul 5, 2024
sjahr
sjahr previously approved these changes Jul 17, 2024
@sea-bass
Copy link
Contributor Author

It does seem like ros2_control has thrown yet another curveball at us here... I'll take a look later if I can will myself to

@sjahr
Copy link
Contributor

sjahr commented Jul 17, 2024

Damn, thanks!

@sea-bass
Copy link
Contributor Author

sea-bass commented Jul 18, 2024

This is the PR that broke things -- fixing now
ros-controls/ros2_control#1585

Of course, this means that non-rolling CI will now fail, so CI stuff will need to be modified to be on different branches, etc.

I recommend that someone with admin power branch out humble, iron, and jazzy branches and keep those respective distros' CI on those. Then, the top-level README with all the status badges should be updated.

@sea-bass sea-bass force-pushed the remove-mimic-tags branch 2 times, most recently from acf116c to 7b4de49 Compare July 18, 2024 01:35
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.26%. Comparing base (743d20f) to head (2a735e6).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   0.00%   40.26%   +40.26%     
==========================================
  Files          5       20       +15     
  Lines        352      524      +172     
  Branches       0       33       +33     
==========================================
+ Hits           0      211      +211     
+ Misses       352      308       -44     
- Partials       0        5        +5     
Flag Coverage Δ
unittests 40.26% <100.00%> (+40.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr merged commit 5f0c39a into PickNikRobotics:main Jul 18, 2024
11 checks passed
@sjahr
Copy link
Contributor

sjahr commented Jul 18, 2024

Thank you @sea-bass !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants