Multi zoom level support for caret #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedejeanne
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Some minor suggestions to improve readability.
Also, please check the whole class and see if you can:
- Reduce the visibility of some of the methods with
package protected(default) visibility - Rename some other parameters in methods
xyzInPixelsso they are also calledxInPixels/yInPixelsetc
...org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/custom/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
...org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/custom/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_styled_text_caret
branch
from
0b8ac01 to
6085f29
Compare
fedejeanne
reviewed
Jun 24, 2024
...org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/custom/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
2 tasks
amartya4256
force-pushed
the
multi_zoom_level_styled_text_caret
branch
4 times, most recently
from
7aff855 to
113a070
Compare
HeikoKlare
requested changes
Jun 27, 2024
...g.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/CommonWidgetsDPIChangeHandlers.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Show resolved
Hide resolved
HeikoKlare
reviewed
Jun 27, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_styled_text_caret
branch
3 times, most recently
from
f5f201c to
76688cd
Compare
HeikoKlare
reviewed
Jun 27, 2024
There was a problem hiding this comment.
The changes look good now. In particular, I did not find any faulty direct access to x, y, width and height not being replaced by the new value-in-pixel getters.
I have also successfully tested the changes in an SDK product at 100%, 150% and 200%.
I have only minor remarks left.
...les/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
Outdated
Show resolved
Hide resolved
...les/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
Outdated
Show resolved
Hide resolved
|
@fedejeanne anything left to do from your side? |
amartya4256
force-pushed
the
multi_zoom_level_styled_text_caret
branch
from
76688cd to
329a630
Compare
HeikoKlare
approved these changes
Jun 28, 2024
fedejeanne
requested changes
Jun 28, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Caret.java
Outdated
Show resolved
Hide resolved
This commit scales the caret on a DPI change event on styled text. It uses the line height of the styled text to set on caret. The height and width field in the caret are storing data in points now and not in pixels. We do so to avail the scaling refernece. Also we use SWT.DEFAULT to ignore setting of width. It is useful when we set the new height on DPI change since the preferred width of the caret is loadeed from preferences on the Caret creation. Contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
multi_zoom_level_styled_text_caret
branch
from
329a630 to
29bb0a4
Compare
fedejeanne
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues
Requires
Note: Only the last commit in this PR is to be reviewed. Previous commit(s) belong to the prerequisite PR(s)
Description
This PR allows the caret to scale on a DPI change event on styled text. It uses the line height of the styled text to set on caret. The height and width field in the caret are storing data in points now and not in pixels. We do so to avail the scaling refernece. Also we use SWT.DEFAULT to ignore setting of width. It is useful when we set the new height on DPI change since the preferred width of the caret is loadeed from preferences on the Caret creation.
Contributes to #62 and #127