Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenJ9PropsExt properties for serviceability_jvmti_j9 #34

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add OpenJ9PropsExt properties for serviceability_jvmti_j9 #34

merged 1 commit into from
Oct 10, 2022

Conversation

JasonFengJ9
Copy link
Member

vm.cds is set to false for serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java which is specific to hotspot sharedclass;
vm.flagless is set to true for serviceability/jvmti/RedefineClasses/RedefineLeak.java which OpenJ9 passes;
vm.opt.final.ClassUnloading is set to false for serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java which looks for a hotspot specific Class unloading: has_previous_versions = false.

Related to eclipse-openj9/openj9#16074

FYI @tajila

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9
Add OpenJ9PropsExt properties for serviceability_jvmti_j9
89ec672 
vm.cds is set to false for
serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java
which is specific to hotspot sharedclass;
vm.flagless is set to true for
serviceability/jvmti/RedefineClasses/RedefineLeak.java which OpenJ9
passes;
vm.opt.final.ClassUnloading is set to false for
serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java which
looks for a hotspot specific "Class unloading: has_previous_versions =
false".

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@babsingh
Copy link
Member

babsingh commented Oct 7, 2022

jenkins test sanity.functional,extended.functional amac jdk19

@babsingh
Copy link
Member

babsingh commented Oct 7, 2022

Do the three JVMTI tests in eclipse-openj9/openj9#16074 pass with this PR?

@pshipton pshipton mentioned this pull request Oct 7, 2022
Merged
@JasonFengJ9
Copy link
Member Author

jenkins test extended.openjdk amac jdk19

@JasonFengJ9
Copy link
Member Author

extended.openjdk PR build still shows the errors eclipse-openj9/openj9#16074 due to the test framework taking the default JDK19 extension repo instead of this PR.
Launched an internal grinder w/ this change and the three tests in question are skipped or passed.

@babsingh
Copy link
Member

babsingh commented Oct 10, 2022 •
edited
Loading

re #34 (comment):

fyi @AdamBrousseau, @llxia. In the PR builds, the test framework doesn't take the changes from the PR.

@babsingh
Copy link
Member

babsingh commented Oct 10, 2022 •
edited
Loading

Impact on the tests in eclipse-openj9/openj9#16074 from local testing

https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java

The above test won't run since OpenJ9 does not support ClassUnloading i.e. it has been set to false.

 * @requires vm.opt.final.ClassUnloading
 * @requires vm.flagless

https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java

The above test won't run either since it requires -XX:+UnlockDiagnosticVMOptions, and this option is not supported by OpenJ9.

https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java

The above test runs and passes with OpenJ9.

babsingh
babsingh approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes work as expected.

@babsingh babsingh merged commit 629c463 into ibmruntimes:openj9 Oct 10, 2022
This was referenced Oct 11, 2022
Closed
Open
@JasonFengJ9 JasonFengJ9 deleted the jvmitprops branch October 11, 2022 11:58
@JasonFengJ9
Copy link
Member Author

Created ibmruntimes/openj9-openjdk-jdk#506

@JasonFengJ9 JasonFengJ9 mentioned this pull request Jun 14, 2023
Open
@pshipton pshipton mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonFengJ9 @babsingh