Remove deprecated parameters and warning about getting robot description from parameter. #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
destogl
commented
Dec 11, 2023
destogl
commented
- Some time ago we agreed that getting a robot description from a parameter is not deprecated and we should support both.
- Also removing deprecated parameters from master, as it is end of 2023.
github-actions
bot
requested review from
aprotyas,
bmagyar,
duringhof,
mhubii and
VanshGehlot
destogl
force-pushed
the
cm-remove-deprecations
branch
from
e61a389
to
a86bc40
Compare
…ion from parameter.
destogl
force-pushed
the
cm-remove-deprecations
branch
from
9d1a17d
to
35ad40e
Compare
|
This pull request is in conflict. Could you fix it @destogl? |
|
obsolete in favor of #1237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.