Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rqt_cm] Add CM as dependency #1447

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[rqt_cm] Add CM as dependency #1447

merged 1 commit into from
Mar 26, 2024

Conversation

christophfroehlich
Copy link
Contributor

If controller_manager itself is not built, then one gets an error at launching rqt_controller_manager

    from controller_manager.controller_manager_services import (
ModuleNotFoundError: No module named 'controller_manager'

imported here

ros2_control/rqt_controller_manager/rqt_controller_manager/controller_manager.py

Lines 20 to 26 in 20e01d8

from controller_manager.controller_manager_services import (
configure_controller,
list_controllers,
load_controller,
switch_controllers,
unload_controller,
)

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Mar 18, 2024
saikishor
saikishor approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency is very clear. Thanks for fixing it

fmauch
fmauch approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitively needed, thanks for catching this!

olivier-stasse
olivier-stasse approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thanks.

@christophfroehlich christophfroehlich mentioned this pull request Mar 23, 2024
Merged
bmagyar
bmagyar approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed! Thank you

@bmagyar bmagyar merged commit b1288bd into master Mar 26, 2024
7 of 12 checks passed
@bmagyar bmagyar deleted the rqt_cm_dependency branch March 26, 2024 08:53
mergify bot pushed a commit that referenced this pull request Mar 26, 2024
@christophfroehlich @mergify
Add cm as dependency to rqt_cm (#1447)
ad35df2 
(cherry picked from commit b1288bd)
mergify bot pushed a commit that referenced this pull request Mar 26, 2024
@christophfroehlich @mergify
Add cm as dependency to rqt_cm (#1447)
25a49fd 
(cherry picked from commit b1288bd)
This was referenced Mar 26, 2024
Merged
Merged
bmagyar pushed a commit that referenced this pull request Mar 26, 2024
@mergify
Add cm as dependency to rqt_cm (#1447) (#1459)
371a500
bmagyar pushed a commit that referenced this pull request Mar 26, 2024
@mergify
Add cm as dependency to rqt_cm (#1447) (#1460)
fd932d0
This was referenced Jun 25, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@fmauch fmauch fmauch approved these changes

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@livanov93 livanov93 Awaiting requested review from livanov93

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christophfroehlich @olivier-stasse @fmauch @bmagyar @saikishor