Deactivate the controllers when they return error similar to the hard…

[saikishor]

Hello!

This is something we have discussed long back in one of the WG meetings to unify the approach with HW and controllers. Right now, when the hardware returns ERROR, it currently deactivates the controllers that use the hardware's interfaces.

Likewise, we want to enforce that if a controller returns an error, we would like to deactivate it to avoid situations in the next cycles. Moreover, this return info from the controllers are not used at all, so, I think it would make sense to put them to proper use.

Thank you

[codecov]

Codecov Report

Attention: Patch coverage is 42.16867% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 62.54%. Comparing base (16fbde3) to head (45ea56a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   62.67%   62.54%   -0.14%     
==========================================
  Files          96       96              
  Lines       11311    11394      +83     
  Branches     8151     8210      +59     
==========================================
+ Hits         7089     7126      +37     
- Misses        715      726      +11     
- Partials     3507     3542      +35     

Flag	Coverage Δ
unittests	62.54% <42.16%> (-0.14%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controller_manager/src/controller_manager.cpp	68.38% <87.50%> (+0.32%)	⬆️
...r_manager/test/test_controller/test_controller.cpp	82.22% <66.66%> (-1.12%)	⬇️
...est_controller_manager_hardware_error_handling.cpp	43.55% <36.11%> (-1.59%)	⬇️

[christophfroehlich]

I'm fine with that changes, thanks! But it's missing tests :/

[christophfroehlich]

LGTM, Thanks for the quick changes!

[bmagyar]

Very nice, thanks!