[CI] Add jazzy and other minor updates #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophfroehlich
commented
Apr 29, 2024
•
christophfroehlich
commented
- Add Jazzy workflows (I decided to create dedicated files, because it easier to maintain if we branch for jazzy)
- Add filters to run the ROS - workflows only if code has changed, and the doc workflow only if docs have changed. (branches+path filter have to match both to run the workflow)
- Check Docs - workflow now uses the correct branch of control.ros.org (not every page is available on every distro any more).
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
aprotyas,
arne48,
bmagyar,
destogl,
erickisos,
peterdavidfagan and
VanshGehlot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 101 101
Lines 8502 8502
Branches 759 759
=======================================
Hits 7527 7527
Misses 706 706
Partials 269 269
Flags with carried forward coverage won't be shown. Click here to find out more. |
fmauch
approved these changes
May 7, 2024
There was a problem hiding this comment.
Without ros-controls/ros2_control_ci#72 changes seem find, hence approving.
However, it probably makes sense to incorporate that into this PR, as well.
fmauch
approved these changes
May 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Add file type filters to workflows * Add jazzy jobs and update readmes * Checkout correct branch for docs * Deactivate jazzy - coverage build * Specify workflow names * Update upstream pre-commit wf * Update coverage build inputs --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 736d379) # Conflicts: # .github/workflows/rolling-abi-compatibility.yml
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Add file type filters to workflows * Add jazzy jobs and update readmes * Checkout correct branch for docs * Deactivate jazzy - coverage build * Specify workflow names * Update upstream pre-commit wf * Update coverage build inputs --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 736d379) # Conflicts: # .github/workflows/iron-abi-compatibility.yml
This was referenced May 8, 2024
christophfroehlich
added a commit
that referenced
this pull request
May 8, 2024
* Add file type filters to workflows * Add jazzy jobs and update readmes * Checkout correct branch for docs * Deactivate jazzy - coverage build * Specify workflow names * Update upstream pre-commit wf * Update coverage build inputs --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 736d379) # Conflicts: # .github/workflows/iron-abi-compatibility.yml Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
added a commit
that referenced
this pull request
May 8, 2024
* Add file type filters to workflows * Add jazzy jobs and update readmes * Checkout correct branch for docs * Deactivate jazzy - coverage build * Specify workflow names * Update upstream pre-commit wf * Update coverage build inputs --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 736d379) # Conflicts: # .github/workflows/rolling-abi-compatibility.yml Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.