Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies for source build #1533

Merged
merged 4 commits into from
May 11, 2024
Merged

Fix dependencies for source build #1533

merged 4 commits into from
May 11, 2024

Conversation

christophfroehlich
Copy link
Contributor

The source builds consistently fail with the following errors

   sh: 1: ros2: not found
  /__w/ros2_control/ros2_control/ros_ws/src/rna86ha94vo/ros2_control/controller_interface/test/test_controller_interface.cpp:91: Failure
  Expected equality of these values:
    std::system("ros2 param set /testable_controller_interface update_rate 623")
      Which is: 32512
    0

and

  launch_test.py: error: No module named 'launch_ros'

Both come from missing dependencies on ros2cli and launch_ros.

  • I don't think that std::system is necessary and changed this to set the parameter of the node via C++ API.
  • Added launch_ros to the test_dependency of joint_limits

Voilà

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels May 10, 2024
@christophfroehlich christophfroehlich mentioned this pull request May 10, 2024
Closed
@christophfroehlich christophfroehlich changed the title Fix source build Fix dependencies for source build May 10, 2024
@codecov Codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (edfb971) to head (538dd1a).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1533   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files         102      102           
  Lines        8618     8619    +1     
  Branches      774      774           
=======================================
+ Hits         7554     7555    +1     
  Misses        788      788           
  Partials      276      276
Flag Coverage Δ
unittests 87.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...oller_interface/test/test_controller_interface.cpp 100.00% <100.00%> (ø)

saikishor
saikishor approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@bmagyar bmagyar merged commit e260049 into master May 11, 2024
18 of 20 checks passed
@bmagyar bmagyar deleted the fix_source_build branch May 11, 2024 17:48
mergify bot pushed a commit that referenced this pull request May 11, 2024
@christophfroehlich @mergify
Fix dependencies for source build (#1533)
51ebe9b 
* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)
mergify bot pushed a commit that referenced this pull request May 11, 2024
@christophfroehlich @mergify
Fix dependencies for source build (#1533)
6f1836b 
* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)
This was referenced May 11, 2024
Merged
Merged
christophfroehlich added a commit that referenced this pull request May 11, 2024
@mergify @christophfroehlich
Fix dependencies for source build (#1533) (#1535)
77ce3a5 
* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request May 11, 2024
@mergify @christophfroehlich
Fix dependencies for source build (#1533) (#1536)
3c15819 
* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@arne48 arne48 Awaiting requested review from arne48

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@moriarty moriarty Awaiting requested review from moriarty

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @bmagyar @saikishor