Extract robot description into global package (again) #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
extract_robot_description
branch
from
b00f132
to
77256b5
Compare
github-actions
bot
requested review from
aprotyas,
bmagyar,
DasRoteSkelett,
harderthan,
LukasMacha97 and
rosterloh
destogl
approved these changes
Aug 17, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Use global rrbot_description in all examples * Move diffbot description to description package * Move r6bot into description package (cherry picked from commit 83b8f91) # Conflicts: # example_1/package.xml # example_2/package.xml # example_3/package.xml # example_4/package.xml # example_5/package.xml # example_6/package.xml # example_8/package.xml
christophfroehlich
added a commit
that referenced
this pull request
Aug 17, 2023
* Use global rrbot_description in all examples * Move diffbot description to description package * Move r6bot into description package
christophfroehlich
added a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with r6bot, I don't want to copy all meshes etc. for examples sharing the same description.
For this reason, I extract all robot description files into one global package -> xacro-description macros, meshes etc.
The xacro files including/defining the ros2_control remain in their respective example package.