chore(blockifier): explicit creation of AccountTransaction

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 2 dependent PRs (#2354 , #2429 )
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377
• chore(blockifier): explicit creation of AccountTransaction #2331 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-28T11:56:10Z
• Started at 2024-11-28T11:59:00Z
• Started at 2024-11-28T12:16:41Z
• Started at 2024-11-28T15:32:24Z
• Started at 2024-12-01T12:24:20Z
• Started at 2024-12-02T17:17:45Z
• Started at 2024-12-03T11:30:02Z

[codecov]

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (e3165c4) to head (4fd1f29).
Report is 673 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/native_blockifier/src/py_transaction.rs	0.00%	6 Missing ⚠️
crates/starknet_batcher/src/block_builder.rs	72.72%	3 Missing ⚠️
...lockifier/src/transaction/transaction_execution.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2331       +/-   ##
===========================================
+ Coverage   40.10%   60.61%   +20.50%     
===========================================
  Files          26      196      +170     
  Lines        1895    20870    +18975     
  Branches     1895    20870    +18975     
===========================================
+ Hits          760    12650    +11890     
- Misses       1100     7411     +6311     
- Partials       35      809      +774     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/starknet_batcher/src/block_builder.rs line 175 at r1 (raw file):

                        BlockifierTransaction::L1Handler(l1_handler_tx.clone())
                    }
                };

Better to have a from for this particular case (hide the irrelevant flags). Non-blocking

Code quote:

                let executable_tx = match tx {
                    Transaction::Account(account_tx) => {
                        BlockifierTransaction::Account(AccountTransaction {
                            // TODO(yair): Avoid this clone.
                            tx: account_tx.clone(),
                            only_query: false,
                        })
                    }
                    Transaction::L1Handler(l1_handler_tx) => {
                        // TODO(yair): Avoid this clone.
                        BlockifierTransaction::L1Handler(l1_handler_tx.clone())
                    }
                };

[avivg-starkware]

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

---

crates/starknet_batcher/src/block_builder.rs line 175 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Better to have a from for this particular case (hide the irrelevant flags). Non-blocking

Thanks. will do, added a TODO

[Yoni-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)