chore(blockifier): remove only_qury from IvokeTxArgs

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): access self.execution_flags instead of passing as args #2491
• chore(blockifier): rename fn account_invoke_tx to invoke_tx_with_default_flags #2479
• chore(blockifier): remove declare.rs deploy_account.rs invoke.rs from blockifier #2478
• chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool #2470
• chore(blockifier): remove only_qury from IvokeTxArgs #2437 👈 (View in Graphite)
• chore(blockifier): add new constructor to AccountTransaction #2431
• chore(blockifier): add struct ExecutionFlags to AccTx & use instead of transaction::ExecutionFlags #2429
• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 1 other dependent PR (#2354 )
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377
• chore(blockifier): explicit creation of AccountTransaction #2331
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-03T15:25:49Z
• Started at 2024-12-03T15:35:10Z
• Started at 2024-12-04T14:00:52Z
• Started at 2024-12-05T09:33:42Z
• Started at 2024-12-05T09:57:31Z
• Started at 2024-12-05T10:01:04Z
• Started at 2024-12-05T11:49:22Z
• Started at 2024-12-05T14:31:02Z
• Started at 2024-12-05T15:46:28Z
• Started at 2024-12-05T19:51:20Z
• Started at 2024-12-05T20:22:41Z
• Started at 2024-12-05T21:22:06Z
• Started at 2024-12-05T21:23:30Z
• Started at 2024-12-05T21:54:22Z
• Started at 2024-12-05T21:54:47Z
• Started at 2024-12-05T21:55:16Z
• Started at 2024-12-05T21:55:20Z
• Started at 2024-12-06T08:16:42Z

[Yoni-Starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (e3165c4) to head (cb264d9).
Report is 728 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2437       +/-   ##
===========================================
+ Coverage   40.10%   72.05%   +31.94%     
===========================================
  Files          26      101       +75     
  Lines        1895    13528    +11633     
  Branches     1895    13528    +11633     
===========================================
+ Hits          760     9747     +8987     
- Misses       1100     3366     +2266     
- Partials       35      415      +380     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[avivg-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 310 at r2 (raw file):

    #[case] tx_version: TransactionVersion,
    #[case] resource_bounds: ValidResourceBounds,
    #[values(true, false)] only_query: bool,

when removing 'only_query' from InvokeTxArgs this bool is no longer used. the test anyway pass, it doesn't seem like 'only_query' is used to effect the run. @Yoni-Starkware Do you think removing it is wanted?

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 188 at r2 (raw file):

    cairo_version: CairoVersion,
    version: TransactionVersion,
    only_query: bool,

same as above.
it doesn't seem like 'only_query' is used to effect the run.
@Yoni-Starkware Do you think removing it is wanted?

[Yoni-Starkware]

Reviewed 3 of 4 files at r3.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 310 at r2 (raw file):

Previously, avivg-starkware wrote…

when removing 'only_query' from InvokeTxArgs this bool is no longer used. the test anyway pass, it doesn't seem like 'only_query' is used to effect the run. @Yoni-Starkware Do you think removing it is wanted?

It's okay to remove it from this one.
execution_falvors_test tests this bool extensively

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 188 at r2 (raw file):

Previously, avivg-starkware wrote…

same as above.
it doesn't seem like 'only_query' is used to effect the run.
@Yoni-Starkware Do you think removing it is wanted?

Yes - if the tests pass this bool directly to the AccountTransaction now, you can remove it.

---

crates/blockifier/src/transaction/test_utils.rs line 307 at r3 (raw file):

pub fn account_invoke_tx(invoke_args: InvokeTxArgs) -> AccountTransaction {
    let only_query = invoke_args.only_query;
    let execution_flags = ExecutionFlags { only_query, ..ExecutionFlags::default() };

Use new_with_default_flags

Code quote:

    let execution_flags = ExecutionFlags::default();
    AccountTransaction { tx: invoke_tx(invoke_args), execution_flags }

[avivg-starkware]

Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 310 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

It's okay to remove it from this one.
execution_falvors_test tests this bool extensively

cool perfect

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 188 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Yes - if the tests pass this bool directly to the AccountTransaction now, you can remove it.

thanks!

[avivg-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/test_utils.rs line 307 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Use new_with_default_flags

Done in following PR #2479

[avivg-starkware]

Reviewed 2 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)