chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): access self.execution_flags instead of passing as args #2491
• chore(blockifier): rename fn account_invoke_tx to invoke_tx_with_default_flags #2479
• chore(blockifier): remove declare.rs deploy_account.rs invoke.rs from blockifier #2478
• chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool #2470 👈 (View in Graphite)
• chore(blockifier): remove only_qury from IvokeTxArgs #2437
• chore(blockifier): add new constructor to AccountTransaction #2431
• chore(blockifier): add struct ExecutionFlags to AccTx & use instead of transaction::ExecutionFlags #2429
• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 1 other dependent PR (#2354 )
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377
• chore(blockifier): explicit creation of AccountTransaction #2331
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-05T09:57:36Z
• Started at 2024-12-05T10:01:10Z
• Started at 2024-12-05T10:11:29Z
• Started at 2024-12-05T11:49:27Z
• Started at 2024-12-05T14:31:08Z
• Started at 2024-12-05T15:46:33Z
• Started at 2024-12-05T19:51:25Z
• Started at 2024-12-05T20:22:46Z
• Started at 2024-12-05T21:22:45Z
• Started at 2024-12-05T21:55:25Z
• Started at 2024-12-06T08:16:48Z
• Started at 2024-12-06T09:28:30Z
• Started at 2024-12-06T09:28:12Z
• Started at 2024-12-06T09:29:01Z
• Started at 2024-12-06T09:29:06Z
• Started at 2024-12-06T09:29:13Z
• Started at 2024-12-06T15:16:35Z

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (e3165c4) to head (d2d4ca4).
Report is 730 commits behind head on main.

Files with missing lines	Patch %	Lines
...lockifier/src/transaction/transaction_execution.rs	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2470       +/-   ##
===========================================
+ Coverage   40.10%   72.04%   +31.94%     
===========================================
  Files          26      101       +75     
  Lines        1895    13524    +11629     
  Branches     1895    13524    +11629     
===========================================
+ Hits          760     9744     +8984     
- Misses       1100     3365     +2265     
- Partials       35      415      +380     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/concurrency/worker_logic.rs line 128 at r1 (raw file):

        let mut transactional_state =
            TransactionalState::create_transactional(&mut tx_versioned_state);
        let execution_result = tx.execute_raw(&mut transactional_state, self.block_context, true);

Suggestion:

        let concurrency_mode = true;
        let execution_result = tx.execute_raw(&mut transactional_state, self.block_context, concurrency_mode)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 106 at r1 (raw file):

        // Executing a single transaction cannot be done in a concurrent mode.
        let tx_execution_result =
            tx.execute_raw(&mut transactional_state, &self.block_context, false);

Suggestion:

use crate::transaction::errors::TransactionExecutionError;
use crate::transaction::objects::TransactionExecutionInfo;
use crate::transaction::transaction_execution::Transaction;
use crate::transaction::transactions::ExecutableTransaction;

#[cfg(test)]
#[path = "transaction_executor_test.rs"]
            block_context,
            bouncer: Bouncer::new(bouncer_config),
            config,
            block_state: Some(block_state),
        }
    }

    /// Executes the given transaction on the state maintained by the executor.
    /// Returns the execution result (info or error) if there is room for the transaction;
    /// Otherwise, returns BlockFull error.
    pub fn execute(
        &mut self,
        tx: &Transaction,
    ) -> TransactionExecutorResult<TransactionExecutionInfo> {
        let mut transactional_state = TransactionalState::create_transactional(
            self.block_state.as_mut().expect(BLOCK_STATE_ACCESS_ERR),
        );

        // Executing a single transaction cannot be done in a concurrent mode.
        let concurrency_mode = false;
        let tx_execution_result =
            tx.execute_raw(&mut transactional_state, &self.block_context, concurrency_mode);

[avivg-starkware]

Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 106 at r1 (raw file):

        // Executing a single transaction cannot be done in a concurrent mode.
        let tx_execution_result =
            tx.execute_raw(&mut transactional_state, &self.block_context, false);

Done.

---

crates/blockifier/src/concurrency/worker_logic.rs line 128 at r1 (raw file):

        let mut transactional_state =
            TransactionalState::create_transactional(&mut tx_versioned_state);
        let execution_result = tx.execute_raw(&mut transactional_state, self.block_context, true);

Done.

[Yoni-Starkware]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[avivg-starkware]

Reviewed 2 of 7 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)