chore(blockifier): add new constructor to AccountTransaction

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): access self.execution_flags instead of passing as args #2491
• chore(blockifier): rename fn account_invoke_tx to invoke_tx_with_default_flags #2479
• chore(blockifier): remove declare.rs deploy_account.rs invoke.rs from blockifier #2478
• chore(blockifier): remove struct ExecutionFlags and replace w concurrency_mode bool #2470
• chore(blockifier): remove only_qury from IvokeTxArgs #2437
• chore(blockifier): add new constructor to AccountTransaction #2431 👈 (View in Graphite)
• chore(blockifier): add struct ExecutionFlags to AccTx & use instead of transaction::ExecutionFlags #2429
• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 1 other dependent PR (#2354 )
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377
• chore(blockifier): explicit creation of AccountTransaction #2331
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-03T13:29:07Z
• Started at 2024-12-03T13:42:20Z
• Started at 2024-12-03T14:08:07Z
• Started at 2024-12-03T14:09:23Z
• Started at 2024-12-03T14:10:43Z
• Started at 2024-12-03T14:47:24Z
• Started at 2024-12-03T15:25:41Z
• Started at 2024-12-03T15:35:05Z
• Started at 2024-12-04T14:00:48Z
• Started at 2024-12-05T09:57:25Z
• Started at 2024-12-05T10:01:00Z
• Started at 2024-12-05T14:30:52Z
• Started at 2024-12-05T15:46:21Z
• Started at 2024-12-05T19:51:13Z
• Started at 2024-12-05T20:22:35Z
• Started at 2024-12-05T21:21:06Z
• Started at 2024-12-05T21:21:30Z
• Started at 2024-12-05T21:21:30Z
• Started at 2024-12-05T21:21:59Z
• Started at 2024-12-05T21:22:04Z

[codecov]

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.92%. Comparing base (e3165c4) to head (4bb5f5b).
Report is 728 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/native_blockifier/src/py_transaction.rs	0.00%	3 Missing ⚠️
...lockifier/src/transaction/transaction_execution.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2431       +/-   ##
===========================================
+ Coverage   40.10%   58.92%   +18.82%     
===========================================
  Files          26      174      +148     
  Lines        1895    19663    +17768     
  Branches     1895    19663    +17768     
===========================================
+ Hits          760    11587    +10827     
- Misses       1100     7336     +6236     
- Partials       35      740      +705     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 3 of 6 files at r1, 6 of 8 files at r2, all commit messages.
Reviewable status: 9 of 11 files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/account_transaction.rs line 132 at r2 (raw file):

    );

    pub fn new(tx: Transaction) -> Self {

Suggestion:

pub fn new_with_default_flags(t

---

crates/blockifier/src/transaction/account_transaction.rs line 143 at r2 (raw file):

        };
        AccountTransaction { tx, execution_flags }
    }

It seems like there is only one place that needs this flag. So better to remove it.

Also, don't use default here - for readability.

Suggestion:

    // Creates an account transaction with flags that are suitable for sequencing.
    pub fn new_for_sequencing(tx: Transaction) -> Self {
        let execution_flags = ExecutionFlags {
            only_query: false,
            charge_fee: enforce_fee(&tx, false),
            validate: true,
        };
        AccountTransaction { tx, execution_flags }
    }

[avivg-starkware]

Reviewable status: 0 of 11 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/account_transaction.rs line 143 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

It seems like there is only one place that needs this flag. So better to remove it.

Also, don't use default here - for readability.

Done

---

crates/blockifier/src/transaction/account_transaction.rs line 132 at r2 (raw file):

    );

    pub fn new(tx: Transaction) -> Self {

Done

[Yoni-Starkware]

Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[avivg-starkware]

Reviewed 7 of 11 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)