chore(blockifier): rename fn account_invoke_tx to invoke_tx_with_default_flags #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
|
This change is |
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
2 times, most recently
from
f555aff to
6daaa50
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
513b7e2 to
7045c45
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
6daaa50 to
ab084d7
Compare
Yoni-Starkware
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
7045c45 to
a196512
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
ab084d7 to
6cf2fd9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
===========================================
+ Coverage 40.10% 72.01% +31.91%
===========================================
Files 26 98 +72
Lines 1895 13512 +11617
Branches 1895 13512 +11617
===========================================
+ Hits 760 9731 +8971
- Misses 1100 3366 +2266
- Partials 35 415 +380 ☔ View full report in Codecov by Sentry. |
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
a196512 to
4dfbbaa
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
6cf2fd9 to
abd6993
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
4dfbbaa to
488fd81
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
abd6993 to
86eaf8f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
488fd81 to
a16601f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
86eaf8f to
4de45ba
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
a16601f to
f46f914
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
4de45ba to
774db28
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
f46f914 to
5baaa91
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
774db28 to
44111ed
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
5baaa91 to
5893842
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
44111ed to
af6a734
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
5893842 to
a863fa6
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
af6a734 to
dca892f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
2 times, most recently
from
07fcc7f to
7b1090a
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
2 times, most recently
from
d71364e to
7c11b44
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
3 times, most recently
from
175e87b to
ddcbf6f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
7c11b44 to
cab341a
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
branch
from
ddcbf6f to
175e87b
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
cab341a to
45a5f8f
Compare
avivg-starkware
commented
Dec 6, 2024
There was a problem hiding this comment.
Reviewed 10 of 12 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
avivg-starkware
changed the base branch from
avivg/blockifier/remove_invoke_declare_deploy_account_from_blocki
to
graphite-base/2479
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
45a5f8f to
99f5d0a
Compare
avivg-starkware
force-pushed
the
graphite-base/2479
branch
from
175e87b to
606fce3
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/rename_fn_account_invoke_tx
branch
from
99f5d0a to
3524b51
Compare
avivg-starkware
deleted the
avivg/blockifier/rename_fn_account_invoke_tx
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.