chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx()

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• chore(blockifier): use test_utils::invoke_tx() instead of trans::test_utils::account_invoke_tx() #2428 : 2 dependent PRs (#2354 , #2429 ) 👈 (View in Graphite)
• chore(blockifier): invoke() declare() deploy_account() change ret val to api_tx #2412
• chore(blockifier): enforce_fee() impl by api::executable_transaction::AccountTransaction #2377
• chore(blockifier): explicit creation of AccountTransaction #2331
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-03T12:13:52Z
• Started at 2024-12-03T12:16:37Z
• Started at 2024-12-03T12:17:07Z
• Started at 2024-12-03T12:19:40Z
• Started at 2024-12-03T13:07:43Z
• Started at 2024-12-03T13:11:01Z
• Started at 2024-12-03T14:08:56Z
• Started at 2024-12-03T14:08:39Z
• Started at 2024-12-03T14:09:12Z
• Started at 2024-12-03T14:08:56Z
• Started at 2024-12-03T14:09:11Z
• Started at 2024-12-03T14:09:31Z
• Started at 2024-12-03T14:46:56Z
• Started at 2024-12-03T15:34:50Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (e3165c4) to head (b523e04).
Report is 692 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2428       +/-   ##
===========================================
+ Coverage   40.10%   71.41%   +31.31%     
===========================================
  Files          26      102       +76     
  Lines        1895    13623    +11728     
  Branches     1895    13623    +11728     
===========================================
+ Hits          760     9729     +8969     
- Misses       1100     3480     +2380     
- Partials       35      414      +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 593 at r1 (raw file):

        calldata: recurse_calldata(test_contract_address, true, 3),
        nonce: nonce_manager.next(account_address),
        only_query,

Do we still need this on InvokeTxArgs?

Code quote:

        only_query,

[Yoni-Starkware]

Reviewed 1 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

[Yoni-Starkware]

Reviewable status: 3 of 5 files reviewed, all discussions resolved

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 593 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Do we still need this on InvokeTxArgs?

Non-blocking, let it be for now

[Yoni-Starkware]

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/test_utils.rs line 297 at r1 (raw file):

    let only_query = invoke_args.only_query;
    AccountTransaction { tx: invoke_tx(invoke_args), only_query }
}

So, can you delete this now?

Code quote:

pub fn account_invoke_tx(invoke_args: InvokeTxArgs) -> AccountTransaction {
    let only_query = invoke_args.only_query;
    AccountTransaction { tx: invoke_tx(invoke_args), only_query }
}

[avivg-starkware]

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 593 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Non-blocking, let it be for now

It seems like it is still used.
though strangely, I created a PR removing it and it works.
I need to look into this.
my source of confusion is that test_account_flow_test doesn't fail although info is lost after the removal of only_query from invoke_tx_args

link to code:

sequencer/crates/blockifier/src/transaction/account_transactions_test.rs

Line 314 in ccb5c8d

#[values(true, false)] only_query: bool,

PR:
#2437

---

crates/blockifier/src/transaction/test_utils.rs line 297 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

So, can you delete this now?

this is my intention. It is still used quite a lot in the code. added a TODO.

[Yoni-Starkware]

Reviewable status: 3 of 5 files reviewed, all discussions resolved

[avivg-starkware]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)