chore(sequencing): remove ProposalChunk

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• chore(consensus): remove irrelevant TODO items #2671
• chore(sequencing): remove ConsensusMessage and Proposal from proto #2559
• chore(sequencing): remove ConsensusMessage from context #2533
• fix(sequencing): make repropose use the proper channel #2532
• chore(sequencing): remove ConsensusMessage from simulation network #2528
• chore(sequencing): remove ConsensusMessage from stream_handler_test #2526
• chore(sequencing): remove ConsensusMessage from converter test #2525
• chore(sequencing): remove mock context from manager_test.rs #2524
• chore(sequencing): add specific print message for wrong tx type #2518
• chore(sequencing): replace BTreeMap with HashMap in StreamHandler #2517
• chore(sequencing): remove ProposalChunk #2512 👈 (View in Graphite)
• chore(sequencing): remove ProposalWrapper #2510
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-08T10:09:26Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.99%. Comparing base (e3165c4) to head (307e662).
Report is 808 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2512       +/-   ##
===========================================
- Coverage   40.10%   17.99%   -22.11%     
===========================================
  Files          26      119       +93     
  Lines        1895    14058    +12163     
  Branches     1895    14058    +12163     
===========================================
+ Hits          760     2530     +1770     
- Misses       1100    11257    +10157     
- Partials       35      271      +236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[asmaastarkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware and @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/types.rs line 31 at r1 (raw file):

    /// The chunks of content returned when iterating the proposal.
    // In practice I expect this to match the type sent to the network
    // (papyrus_protobuf::ConsensusMessage), and not to be specific to just the block's content.

Replace this with doc to ProposalPart (it should contain the ProposalInit + Fin, right?)

Code quote:

    /// The chunks of content returned when iterating the proposal.
    // In practice I expect this to match the type sent to the network
    // (papyrus_protobuf::ConsensusMessage), and not to be specific to just the block's content.

[asmaastarkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware and @matan-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 134 at r1 (raw file):

#[async_trait]
impl ConsensusContext for SequencerConsensusContext {
    // TODO(guyn): Switch to ProposalPart when done with the streaming integration.

does this comment still apply?

[guy-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @asmaastarkware and @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/types.rs line 31 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

Replace this with doc to ProposalPart (it should contain the ProposalInit + Fin, right?)

Done.

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 134 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

does this comment still apply?

No, I'm removing it. Thanks!

[asmaastarkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[matan-starkware]

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

---

crates/sequencing/papyrus_consensus/src/test_utils.rs line 21 at r2 (raw file):

#[derive(Debug, PartialEq, Clone)]
pub struct MockProposalPart(pub u64);

Please rename this FakeProposalPart or TestProposalPart. A Mock is something which you set expectations on. A Fake is a simplified version for the sake of testing.

Separate PR

Code quote:

#[derive(Debug, PartialEq, Clone)]
pub struct MockProposalPart(pub u64);

[guy-starkware]

Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @asmaastarkware and @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/test_utils.rs line 21 at r2 (raw file):

Previously, matan-starkware wrote…

Please rename this FakeProposalPart or TestProposalPart. A Mock is something which you set expectations on. A Fake is a simplified version for the sake of testing.

Separate PR

Done.

[guy-starkware]

Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[guy-starkware]

Merge activity

• Dec 10, 9:07 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 10, 9:08 AM EST: A user merged this pull request with Graphite.