Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencing): remove ConsensusMessage from stream_handler_test #2526

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.06%. Comparing base (27b67fe) to head (d087266).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           guyn/streams/remove_consensus_message    #2526      +/-   ##
=========================================================================
- Coverage                                  36.04%   30.06%   -5.98%     
=========================================================================
  Files                                         51       87      +36     
  Lines                                       6309    10509    +4200     
  Branches                                    6309    10509    +4200     
=========================================================================
+ Hits                                        2274     3160     +886     
- Misses                                      3734     7023    +3289     
- Partials                                     301      326      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from cb9941d to 0afc2fc Compare December 8, 2024 13:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 8ffa36a to 2d839b9 Compare December 8, 2024 13:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 0afc2fc to 40b4049 Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2d839b9 to f10498c Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 40b4049 to 33109ec Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from f10498c to f2d0060 Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 33109ec to 588e000 Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from f2d0060 to fcbba9c Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 588e000 to 7527dcc Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from fcbba9c to 15a1b58 Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 7527dcc to 1c51cfc Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 15a1b58 to 2697e22 Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 1c51cfc to 06a3192 Compare December 10, 2024 08:25
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2697e22 to 0a4ca1d Compare December 10, 2024 08:26
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 06a3192 to e5c4ff8 Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from cc50c7b to 8f057b2 Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from a6ac1ff to fbe0592 Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 8f057b2 to 27b67fe Compare December 11, 2024 19:29
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from fbe0592 to d087266 Compare December 11, 2024 19:30
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 27b67fe to 3614fe5 Compare December 15, 2024 11:05
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from d087266 to 2cac9f5 Compare December 15, 2024 11:05
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 3614fe5 to 93f13e3 Compare December 16, 2024 09:06
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 93f13e3 to f19523d Compare December 17, 2024 19:34
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2cac9f5 to 287dd4d Compare December 18, 2024 12:42
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from f19523d to 426005a Compare December 19, 2024 19:09
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 287dd4d to 8ac6a8f Compare December 19, 2024 19:10
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from 426005a to a486758 Compare December 19, 2024 20:45
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 8ac6a8f to 4c39618 Compare December 19, 2024 20:45
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch from a486758 to 5fad1ad Compare December 19, 2024 20:57
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 4c39618 to 8721f13 Compare December 19, 2024 20:57
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message branch 2 times, most recently from 597e3b3 to 81413ec Compare December 20, 2024 06:46
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 8721f13 to 621288d Compare December 20, 2024 06:46
@guy-starkware guy-starkware changed the base branch from guyn/streams/remove_consensus_message to graphite-base/2526 December 20, 2024 07:06
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 621288d to 132246a Compare December 20, 2024 07:07
@guy-starkware guy-starkware changed the base branch from graphite-base/2526 to main December 20, 2024 07:07
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 132246a to 8e948bf Compare December 20, 2024 07:07
@guy-starkware guy-starkware merged commit 6592cd2 into main Dec 20, 2024
14 checks passed
Copy link
Contributor Author

Merge activity

  • Dec 20, 2:30 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants