-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sequencing): remove ConsensusMessage from simulation network #2528
Open
guy-starkware
wants to merge
1
commit into
guyn/streams/remove_consensus_message2
Choose a base branch
from
guyn/streams/remove_consensus_message3
base: guyn/streams/remove_consensus_message2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(sequencing): remove ConsensusMessage from simulation network #2528
guy-starkware
wants to merge
1
commit into
guyn/streams/remove_consensus_message2
from
guyn/streams/remove_consensus_message3
+21
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2024
This was referenced Dec 8, 2024
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 8, 2024 13:57
33e0806
to
27483e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## guyn/streams/remove_consensus_message2 #2528 +/- ##
========================================================================
Coverage ? 9.59%
========================================================================
Files ? 87
Lines ? 10481
Branches ? 10481
========================================================================
Hits ? 1006
Misses ? 9442
Partials ? 33 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 8, 2024
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 9, 2024 13:23
2d839b9
to
f10498c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 9, 2024 13:23
27483e5
to
6e1aa30
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 07:31
f10498c
to
f2d0060
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 07:31
6e1aa30
to
48ddeba
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 07:41
f2d0060
to
fcbba9c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 07:41
48ddeba
to
683ff84
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 08:11
fcbba9c
to
15a1b58
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 08:11
683ff84
to
463c0cc
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 08:24
15a1b58
to
2697e22
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 08:24
463c0cc
to
e6d6c5f
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 08:26
2697e22
to
0a4ca1d
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 08:26
e6d6c5f
to
088e03c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 09:53
0a4ca1d
to
1832e48
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 09:53
088e03c
to
02e5a04
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 10:33
1832e48
to
6d361d6
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 10:33
02e5a04
to
0e6a4eb
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 11:01
6d361d6
to
4769c92
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 11:01
0e6a4eb
to
bb97c32
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 10, 2024 17:01
4769c92
to
a6ac1ff
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 17:01
bb97c32
to
45fa6d6
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 11, 2024 16:52
a6ac1ff
to
fbe0592
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 11, 2024 16:52
45fa6d6
to
8430e7a
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 11, 2024 19:30
fbe0592
to
d087266
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 11, 2024 19:31
8430e7a
to
8a23f86
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 15, 2024 11:05
d087266
to
2cac9f5
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 15, 2024 11:06
8a23f86
to
41666b3
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 18, 2024 12:42
2cac9f5
to
287dd4d
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 18, 2024 12:56
41666b3
to
43790e2
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message2
branch
from
December 19, 2024 19:10
287dd4d
to
8ac6a8f
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 19, 2024 19:10
43790e2
to
e9ddee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had to simplify the test in this file (
simulation_network_receiver_test.rs
) so it now only works with Vote type messages.I'm not sure what would be a good way to also check the proposal channel, or if it is even necessary to add that check.