Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencing): remove ConsensusMessage from simulation network #2528

Open
wants to merge 1 commit into
base: guyn/streams/remove_consensus_message2
Choose a base branch
from

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Dec 8, 2024

I've had to simplify the test in this file (simulation_network_receiver_test.rs) so it now only works with Vote type messages.

I'm not sure what would be a good way to also check the proposal channel, or if it is even necessary to add that check.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (guyn/streams/remove_consensus_message2@d087266). Learn more about missing BASE report.

Additional details and impacted files
@@                           Coverage Diff                            @@
##             guyn/streams/remove_consensus_message2   #2528   +/-   ##
========================================================================
  Coverage                                          ?   9.59%           
========================================================================
  Files                                             ?      87           
  Lines                                             ?   10481           
  Branches                                          ?   10481           
========================================================================
  Hits                                              ?    1006           
  Misses                                            ?    9442           
  Partials                                          ?      33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2d839b9 to f10498c Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 27483e5 to 6e1aa30 Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from f10498c to f2d0060 Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 6e1aa30 to 48ddeba Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from f2d0060 to fcbba9c Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 48ddeba to 683ff84 Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from fcbba9c to 15a1b58 Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 683ff84 to 463c0cc Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 15a1b58 to 2697e22 Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 463c0cc to e6d6c5f Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2697e22 to 0a4ca1d Compare December 10, 2024 08:26
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from e6d6c5f to 088e03c Compare December 10, 2024 08:26
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 0a4ca1d to 1832e48 Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 088e03c to 02e5a04 Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 1832e48 to 6d361d6 Compare December 10, 2024 10:33
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 02e5a04 to 0e6a4eb Compare December 10, 2024 10:33
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 6d361d6 to 4769c92 Compare December 10, 2024 11:01
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 0e6a4eb to bb97c32 Compare December 10, 2024 11:01
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 4769c92 to a6ac1ff Compare December 10, 2024 17:01
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from bb97c32 to 45fa6d6 Compare December 10, 2024 17:01
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from a6ac1ff to fbe0592 Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 45fa6d6 to 8430e7a Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from fbe0592 to d087266 Compare December 11, 2024 19:30
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 8430e7a to 8a23f86 Compare December 11, 2024 19:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from d087266 to 2cac9f5 Compare December 15, 2024 11:05
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 8a23f86 to 41666b3 Compare December 15, 2024 11:06
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 2cac9f5 to 287dd4d Compare December 18, 2024 12:42
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 41666b3 to 43790e2 Compare December 18, 2024 12:56
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message2 branch from 287dd4d to 8ac6a8f Compare December 19, 2024 19:10
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 43790e2 to e9ddee2 Compare December 19, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants