-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sequencing): make repropose use the proper channel #2532
Open
guy-starkware
wants to merge
5
commits into
guyn/streams/remove_consensus_message3
Choose a base branch
from
guyn/streams/repropose_fix
base: guyn/streams/remove_consensus_message3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(sequencing): make repropose use the proper channel #2532
guy-starkware
wants to merge
5
commits into
guyn/streams/remove_consensus_message3
from
guyn/streams/repropose_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2024
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 8, 2024 15:38
b0b4583
to
e9353db
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 9, 2024 09:15
e9353db
to
a387c0e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## guyn/streams/remove_consensus_message3 #2532 +/- ##
==========================================================================
+ Coverage 9.59% 17.67% +8.07%
==========================================================================
Files 87 122 +35
Lines 10481 14112 +3631
Branches 10481 14112 +3631
==========================================================================
+ Hits 1006 2494 +1488
- Misses 9442 11351 +1909
- Partials 33 267 +234 ☔ View full report in Codecov by Sentry. |
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 9, 2024 13:23
27483e5
to
6e1aa30
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 9, 2024 13:23
a387c0e
to
8d2e266
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 07:31
6e1aa30
to
48ddeba
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 07:31
8d2e266
to
434b5ac
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 07:41
48ddeba
to
683ff84
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 07:41
434b5ac
to
946474c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 08:11
683ff84
to
463c0cc
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 08:11
946474c
to
ced6686
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
2 times, most recently
from
December 10, 2024 08:26
e6d6c5f
to
088e03c
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 08:26
ced6686
to
adefee5
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 09:53
088e03c
to
02e5a04
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 09:53
adefee5
to
1828e43
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 10:33
02e5a04
to
0e6a4eb
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 10:33
1828e43
to
e78c63b
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 11:01
0e6a4eb
to
bb97c32
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 11:01
e78c63b
to
281a04c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 10, 2024 17:01
bb97c32
to
45fa6d6
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 10, 2024 17:02
281a04c
to
26d3496
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 11, 2024 16:52
45fa6d6
to
8430e7a
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 11, 2024 16:52
26d3496
to
bb5c0a3
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 11, 2024 19:31
8430e7a
to
8a23f86
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 11, 2024 19:31
bb5c0a3
to
6dfb1bb
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 15, 2024 11:06
8a23f86
to
41666b3
Compare
guy-starkware
force-pushed
the
guyn/streams/repropose_fix
branch
from
December 15, 2024 11:06
6dfb1bb
to
8ebd640
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message3
branch
from
December 18, 2024 12:56
41666b3
to
43790e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In papyrus consensus context, I replaced the old repropose function with a new version that uses the correct proposal channel to send the proposal.