[ControllerInterface] Avoid warning about conversion from int64_t to unsigned int
#1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `unsigned int`
Without this there is a warning. For what I found the best way is to do static cast.
```
ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion]
88 | update_rate_ = get_node()->get_parameter("update_rate").as_int();
```
github-actions
bot
requested review from
bmagyar,
harderthan,
jaron-l,
malapatiravi and
rosterloh
bmagyar
approved these changes
Nov 21, 2023
christophfroehlich
added
the
backport-iron
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
…o `unsigned int` (#1173) Without this there is a warning. For what I found the best way is to do static cast. ``` ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion] 88 | update_rate_ = get_node()->get_parameter("update_rate").as_int(); ``` (cherry picked from commit 2569b76)
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
…o `unsigned int` (#1173) Without this there is a warning. For what I found the best way is to do static cast. ``` ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion] 88 | update_rate_ = get_node()->get_parameter("update_rate").as_int(); ``` (cherry picked from commit 2569b76) # Conflicts: # controller_interface/src/controller_interface_base.cpp
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 20, 2024
…o `unsigned int` (#1173) Without this there is a warning. For what I found the best way is to do static cast. ``` ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion] 88 | update_rate_ = get_node()->get_parameter("update_rate").as_int(); ``` (cherry picked from commit 2569b76)
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this there is a warning. For what I found the best way is to do static cast.
#GitHub-Programming-Rocks