Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): redefine consensus height metric to working height #404

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Aug 12, 2024

This will be more useful than stating the most recent decision when we are stuck on block 0.
Also moved out of Context::decision due to sync


This change is Reviewable

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63%. Comparing base (8dda046) to head (5bf4454).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files         346      346           
  Lines       36280    36279    -1     
  Branches    36280    36279    -1     
=======================================
  Hits        27803    27803           
+ Misses       6174     6173    -1     
  Partials     2303     2303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should make changes in run_consensus.py, in case one node got stuck and didn't start (now height = 0 not None)

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 82930cd to 50123cf Compare August 12, 2024 13:21
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch 2 times, most recently from e9ce6e4 to 965be23 Compare August 12, 2024 13:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 50123cf to 87f86c8 Compare August 13, 2024 10:29
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from 965be23 to de5a450 Compare August 13, 2024 10:29
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 87f86c8 to 33df538 Compare August 13, 2024 13:49
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from de5a450 to 8df6db1 Compare August 13, 2024 13:50
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 33df538 to 5266938 Compare August 13, 2024 13:52
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from 8df6db1 to a0aaaa9 Compare August 13, 2024 13:52
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 5266938 to 8cbcbe3 Compare August 14, 2024 08:13
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from a0aaaa9 to a5fb3d4 Compare August 14, 2024 08:13
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 8cbcbe3 to d825fd2 Compare August 14, 2024 08:34
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from a5fb3d4 to cdeea98 Compare August 14, 2024 08:34
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch 2 times, most recently from 06159c4 to c3f7c35 Compare August 14, 2024 10:28
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch 2 times, most recently from 2f40f68 to 0441cb3 Compare August 14, 2024 10:28
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from c3f7c35 to 619ab4d Compare August 14, 2024 10:35
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from 0441cb3 to 6441573 Compare August 14, 2024 10:35
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_receiver branch from 619ab4d to 54d9fe1 Compare August 14, 2024 12:19
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from 6441573 to bd7c806 Compare August 14, 2024 12:19
@matan-starkware matan-starkware changed the base branch from matan/consensus/m3/add_sync_receiver to graphite-base/404 August 15, 2024 05:55
This will be more useful than stating the most recent decision when we are stuck on block 0.
Also moved out of Context::decision due to sync
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/consensus_height_metric branch from bd7c806 to 5bf4454 Compare August 15, 2024 05:56
@matan-starkware matan-starkware changed the base branch from graphite-base/404 to main August 15, 2024 05:56
@matan-starkware
Copy link
Contributor Author

matan-starkware commented Aug 15, 2024

Merge activity

@matan-starkware matan-starkware merged commit 0eface3 into main Aug 15, 2024
59 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants