-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): redefine consensus height metric to working height #404
feat(consensus): redefine consensus height metric to working height #404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=======================================
Coverage 76.63% 76.63%
=======================================
Files 346 346
Lines 36280 36279 -1
Branches 36280 36279 -1
=======================================
Hits 27803 27803
+ Misses 6174 6173 -1
Partials 2303 2303 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should make changes in run_consensus.py, in case one node got stuck and didn't start (now height = 0 not None)
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
82930cd
to
50123cf
Compare
e9ce6e4
to
965be23
Compare
50123cf
to
87f86c8
Compare
965be23
to
de5a450
Compare
87f86c8
to
33df538
Compare
de5a450
to
8df6db1
Compare
33df538
to
5266938
Compare
8df6db1
to
a0aaaa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
5266938
to
8cbcbe3
Compare
a0aaaa9
to
a5fb3d4
Compare
8cbcbe3
to
d825fd2
Compare
a5fb3d4
to
cdeea98
Compare
06159c4
to
c3f7c35
Compare
2f40f68
to
0441cb3
Compare
c3f7c35
to
619ab4d
Compare
0441cb3
to
6441573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
619ab4d
to
54d9fe1
Compare
6441573
to
bd7c806
Compare
This will be more useful than stating the most recent decision when we are stuck on block 0. Also moved out of Context::decision due to sync
bd7c806
to
5bf4454
Compare
54d9fe1
to
8dda046
Compare
Merge activity
|
This will be more useful than stating the most recent decision when we are stuck on block 0.
Also moved out of Context::decision due to sync
This change is