-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): add sync_topic to test config #412
feat(consensus): add sync_topic to test config #412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 76.63% 76.63% -0.01%
==========================================
Files 348 348
Lines 36298 36310 +12
Branches 36298 36310 +12
==========================================
+ Hits 27816 27825 +9
- Misses 6173 6176 +3
Partials 2309 2309 ☔ View full report in Codecov by Sentry. |
778ca40
to
0039511
Compare
37840e3
to
c240f16
Compare
0039511
to
4557ca6
Compare
c240f16
to
63f95c1
Compare
4557ca6
to
aa41dfc
Compare
63f95c1
to
3b21276
Compare
aa41dfc
to
87b40a7
Compare
3b21276
to
f86cf8e
Compare
87b40a7
to
999504e
Compare
f86cf8e
to
4923e37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)
a discussion (no related file):
Consider using &str
as the time instead of String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @DvirYo-starkware)
a discussion (no related file):
Previously, DvirYo-starkware wrote…
Consider using
&str
as the time instead ofString
I assume time should be type? Meaning sync_topic: &str
? I'm not sure how this would work, since I think the config needs to own the data. This would be ok in Default
since we have a static &str
, but if we actually need to use a command line flag then we would need a real lifetime for the &str
.
I checked all of the papyrus configs and they always use String
not &str
.
999504e
to
2bf24d1
Compare
4923e37
to
8410812
Compare
2bf24d1
to
507ff6e
Compare
8410812
to
d80da87
Compare
507ff6e
to
4347983
Compare
d80da87
to
79c631e
Compare
4347983
to
9a08733
Compare
cd909f6
to
2cec2b7
Compare
5baf732
to
144119e
Compare
2cec2b7
to
89307aa
Compare
144119e
to
e8633e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)
89307aa
to
fcf74df
Compare
e8633e4
to
1d0ada2
Compare
fcf74df
to
bffa577
Compare
1d0ada2
to
8a2db1c
Compare
bffa577
to
62cf873
Compare
8a2db1c
to
0cc24c8
Compare
c7bd97d
to
f8f2723
Compare
d22bed1
to
fdfaaa4
Compare
f8f2723
to
0fc07e5
Compare
fdfaaa4
to
fb09214
Compare
0fc07e5
to
3ffee06
Compare
fb09214
to
f0a4be3
Compare
3ffee06
to
7aaa7cc
Compare
f0a4be3
to
1595302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
1595302
to
e6893b3
Compare
Merge activity
|
This change is