refactor(consensus): consensus handles its network registrations on its own

[matan-starkware]

This is because the network registration logic will become more complex with test sync.
In practice this means that after the initial network config we hold off on spawning the task
until all tasks have been set up.

---

This change is 

[matan-starkware]

• feat(consensus): add metric for sync in consensus and update the simulation script #490
• refactor(consensus): rename notify_decision to decision_reached #465
• feat(consensus): simulations with the test config will use the fake consensus sync #414
• feat(consensus): add sync sender to context to broadcast on decision #413
• feat(consensus): add sync_topic to test config #412
• refactor(consensus): consensus handles its network registrations on its own #409 👈
• refactor(consensus): rename topic in config to network_topic #406
• feat(consensus): redefine consensus height metric to working height #404
• feat(consensus): add sync receiver to consensus #389 : 1 other dependent PR (#403 )
• feat(consensus): add decision fn to consensus context API #387
• refactor(consensus): move run_consensus out of lib.rs #386
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 35 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (6e7b138) to head (3ffee06).
Report is 2 commits behind head on main.

Files	Patch %	Lines
crates/papyrus_node/src/main.rs	27.27%	26 Missing and 6 partials ⚠️
...papyrus_consensus/src/papyrus_consensus_context.rs	40.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   76.59%   76.62%   +0.03%     
==========================================
  Files         348      348              
  Lines       36303    36298       -5     
  Branches    36303    36298       -5     
==========================================
+ Hits        27805    27814       +9     
+ Misses       6195     6176      -19     
- Partials     2303     2308       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.432 ms 64.494 ms 64.566 ms]
change: [-9.9781% -6.4574% -3.3427%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.499 ms 64.570 ms 64.656 ms]
change: [-8.3152% -5.0526% -2.2204%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

[eitanm-starkware]

Reviewed 1 of 2 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.971 ms 66.049 ms 66.137 ms]
change: [-9.7531% -6.3829% -3.3594%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) high mild
4 (4.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.044 ms 66.097 ms 66.161 ms]
change: [-8.6090% -5.0999% -2.1192%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.426 ms 65.496 ms 65.582 ms]
change: [-10.408% -6.6969% -3.4989%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.441 ms 65.551 ms 65.710 ms]
change: [-7.4764% -4.0522% -1.2342%] (p = 0.01 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

[DvirYo-starkware]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.432 ms 65.496 ms 65.573 ms]
change: [-8.8429% -5.5854% -2.7301%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

[eitanm-starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[matan-starkware]

Merge activity

• Aug 15, 8:25 AM EDT: @matan-starkware started a stack merge that includes this pull request via Graphite.
• Aug 15, 8:26 AM EDT: @matan-starkware merged this pull request with Graphite.