Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consensus): simulations with the test config will use the fake consensus sync #414

Merged
merged 1 commit into from
Aug 18, 2024
Merged

feat(consensus): simulations with the test config will use the fake consensus sync #414

merged 1 commit into from
Aug 18, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Aug 12, 2024 •
edited by liorgold2
Loading

This change is Reviewable

This was referenced Aug 12, 2024
Merged
Merged
Merged
Merged
@matan-starkware
Copy link
Contributor Author

matan-starkware commented Aug 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite Graphite

@matan-starkware matan-starkware mentioned this pull request Aug 12, 2024
Merged
@matan-starkware matan-starkware marked this pull request as ready for review August 12, 2024 12:59
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.68%. Comparing base (a37bcb6) to head (13158aa).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/papyrus_node/src/main.rs 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   76.70%   76.68%   -0.02%     
==========================================
  Files         348      348              
  Lines       36331    36345      +14     
  Branches    36331    36345      +14     
==========================================
+ Hits        27867    27871       +4     
- Misses       6143     6154      +11     
+ Partials     2321     2320       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from d61b95f to 3271ddb Compare August 12, 2024 13:20
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 48fb412 to aef6478 Compare August 12, 2024 13:20
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 3271ddb to af748d6 Compare August 12, 2024 13:22
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from aef6478 to 2d724b7 Compare August 12, 2024 13:22
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from af748d6 to 982acae Compare August 12, 2024 13:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 2d724b7 to 7413061 Compare August 12, 2024 13:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 982acae to 61989ac Compare August 12, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 7413061 to cc4e622 Compare August 12, 2024 13:39
@matan-starkware matan-starkware requested review from eitanm-starkware and removed request for ShahakShama August 12, 2024 13:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 61989ac to 6f9e6a4 Compare August 13, 2024 10:29
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from cc4e622 to 2cda04f Compare August 13, 2024 10:30
eitanm-starkware
eitanm-starkware approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 6f9e6a4 to 5810701 Compare August 13, 2024 13:50
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 2cda04f to fea37ac Compare August 13, 2024 13:50
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 5810701 to 9758484 Compare August 13, 2024 13:53
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from fea37ac to 35aa92a Compare August 13, 2024 13:53
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 9758484 to 3f30743 Compare August 14, 2024 08:14
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 35aa92a to 0ed72b6 Compare August 14, 2024 08:14
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 3f30743 to 1db6c2b Compare August 14, 2024 08:35
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from eb4b2f4 to 264e457 Compare August 15, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from abe2568 to 7822dfa Compare August 15, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 264e457 to 94b894e Compare August 15, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 7822dfa to db940c7 Compare August 15, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 94b894e to 6032627 Compare August 15, 2024 07:26
DvirYo-starkware
DvirYo-starkware approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from db940c7 to 18638c7 Compare August 15, 2024 11:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 6032627 to ff01ba1 Compare August 15, 2024 11:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 18638c7 to 5bf308e Compare August 15, 2024 12:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from ff01ba1 to 2084678 Compare August 15, 2024 12:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch from 5bf308e to b450c06 Compare August 15, 2024 12:47
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 2084678 to ae1e80f Compare August 15, 2024 12:47
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_sender_to_context branch 2 times, most recently from 2761f88 to d844dd9 Compare August 15, 2024 13:11
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch 2 times, most recently from 4bdf27f to 16592b4 Compare August 15, 2024 13:11
@matan-starkware matan-starkware changed the base branch from matan/consensus/m3/add_sync_sender_to_context to graphite-base/414 August 15, 2024 13:57
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from 16592b4 to eed6f48 Compare August 15, 2024 13:57
@matan-starkware matan-starkware changed the base branch from graphite-base/414 to main August 15, 2024 13:57
@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from eed6f48 to e4fff99 Compare August 18, 2024 07:11
matan-starkware
matan-starkware commented Aug 18, 2024
View reviewed changes
Copy link
Contributor Author

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m3/add_sync_to_papyrus_main branch from e4fff99 to 13158aa Compare August 18, 2024 09:09
@matan-starkware matan-starkware mentioned this pull request Aug 18, 2024
Merged
asmaastarkware
asmaastarkware approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware
Copy link
Contributor Author

matan-starkware commented Aug 18, 2024 •
edited
Loading

Merge activity

@matan-starkware matan-starkware merged commit 32e3859 into main Aug 18, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asmaastarkware asmaastarkware asmaastarkware approved these changes

@eitanm-starkware eitanm-starkware eitanm-starkware approved these changes

@DvirYo-starkware DvirYo-starkware DvirYo-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matan-starkware @DvirYo-starkware @eitanm-starkware @asmaastarkware