feat(consensus): add metric for sync in consensus and update the simulation script

[matan-starkware]

This change is 

[matan-starkware]

• feat(consensus): add metric for sync in consensus and update the simulation script #490 👈
• refactor(consensus): rename notify_decision to decision_reached #465
• feat(consensus): simulations with the test config will use the fake consensus sync #414
• feat(consensus): add sync sender to context to broadcast on decision #413
• feat(consensus): add sync_topic to test config #412
• refactor(consensus): consensus handles its network registrations on its own #409
• refactor(consensus): rename topic in config to network_topic #406
• feat(consensus): redefine consensus height metric to working height #404
• feat(consensus): add sync receiver to consensus #389 : 1 other dependent PR (#403 )
• feat(consensus): add decision fn to consensus context API #387
• refactor(consensus): move run_consensus out of lib.rs #386
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (32e3859) to head (c1d9ec6).
Report is 4 commits behind head on main.

Files	Patch %	Lines
...pyrus_consensus/src/simulation_network_receiver.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   76.66%   76.71%   +0.04%     
==========================================
  Files         348      348              
  Lines       36345    36366      +21     
  Branches    36345    36366      +21     
==========================================
+ Hits        27863    27897      +34     
+ Misses       6160     6147      -13     
  Partials     2322     2322              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DvirYo-starkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/manager.rs line 71 at r1 (raw file):

                current_height = current_height.unchecked_next();
            },
            sync_height = sync_height(current_height, &mut sync_receiver) => {

I think this will set the count to 1, not increment it by one, is it your intention?

[matan-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus/src/manager.rs line 71 at r1 (raw file):

Previously, DvirYo-starkware wrote…

I think this will set the count to 1, not increment it by one, is it your intention?

Not my intention. I ran simulations where the counter seems to increase as expected (it definitely was above 1).

[asmaastarkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)

[DvirYo-starkware]

crates/sequencing/papyrus_consensus/src/manager.rs line 71 at r1 (raw file):

Previously, matan-starkware wrote…

Not my intention. I ran simulations where the counter seems to increase as expected (it definitely was above 1).

consider using increment_counter! instead

[matan-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus/src/manager.rs line 71 at r1 (raw file):

Previously, DvirYo-starkware wrote…

consider using increment_counter! instead

Done.

[DvirYo-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[matan-starkware]

Merge activity

• Aug 18, 6:54 AM EDT: @matan-starkware started a stack merge that includes this pull request via Graphite.
• Aug 18, 6:55 AM EDT: @matan-starkware merged this pull request with Graphite.