refactor(consensus): rename notify_decision to decision_reached #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2024
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
d17b5d8 to
13577b7
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
008e470 to
706e0e2
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
13577b7 to
eb4b2f4
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
706e0e2 to
dde0497
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
eb4b2f4 to
264e457
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
dde0497 to
fe317e0
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
2 times, most recently
from
94b894e to
6032627
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
2 times, most recently
from
243cbb5 to
6682400
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
6032627 to
ff01ba1
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
6682400 to
32feccb
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
ff01ba1 to
2084678
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
32feccb to
76b8a5f
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
2084678 to
ae1e80f
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
76b8a5f to
2277d0f
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
ae1e80f to
4bdf27f
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
2277d0f to
229709a
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
4bdf27f to
16592b4
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
229709a to
e379e21
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
16592b4 to
eed6f48
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
e379e21 to
01f9460
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
eed6f48 to
e4fff99
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
01f9460 to
20d19b5
Compare
DvirYo-starkware
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
matan-starkware
force-pushed
the
matan/consensus/m3/add_sync_to_papyrus_main
branch
from
e4fff99 to
13158aa
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
20d19b5 to
29733c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 76.66% 76.66%
=======================================
Files 348 348
Lines 36345 36345
Branches 36345 36345
=======================================
Hits 27863 27863
Misses 6160 6160
Partials 2322 2322 ☔ View full report in Codecov by Sentry. |
asmaastarkware
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Merge activity
|
matan-starkware
changed the base branch from
matan/consensus/m3/add_sync_to_papyrus_main
to
graphite-base/465
matan-starkware
force-pushed
the
matan/consensus/m3/rename_notify_decision_to_decision_reached
branch
from
29733c5 to
cdcd9f8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is