Skip to content

CCPP Framework Meeting Minutes 2024 02 05

Dom Heinzeller edited this page Feb 5, 2024 · 13 revisions

Agenda


Attendees: Dustin Swales, Ligia Bernardet, Lulin Xue, Courtney Peverley, Michael Waxmonsky, Matthew Dawson, Jesse Nusbaumer, Dom Heinzeller

GitHub issues/PRs

CCPP Framework (issues, PRs, discussions)

  • #526: Add optional attribute to capgen/prebuild
    • Two proposed solutions, one for capgen and prebuild; this issue is for capgen
    • Reintroduce optional attribute for CCPP physics schemes
    • Schemes test for presence of argument if variable is declared optional in metadata
    • Scheme metadata must have optional if (any) host model uses active other than default (.true.)
    • #529: Draft PR for use of optional attribute in capgen
  • #527: Add tests for optional attribute
  • #528: Fortran 2008 MPI interface for CCPP framework and CCPP (UFS) physics
    • Incompatibility of MPI communicator type (integer for old MPI, MPI_Comm for MPI F08)
    • Currently talking with CCPP users to check if we need to support both (can do via framework, rather ugly)
    • If only MPI F08, then #523; if both, then #530
  • #519: Ready to merge (requires CCPP physics PR as well)
  • #525 (merged): Add new test for active attribute with array transformation (variable actions)

Standard names (issues, PRs, discussions)

  • #57: Steve Sandbach (UKMO) sent a suggestion, need to check if ok with UFS
  • #49: Resolved for now? Create separate sections for different chemical models and describe the names for these models there
  • #56: Waiting for Mike K and Grant F to re-review and approve

New items for discussion

  • https://github.com/NCAR/ccpp-physics/issues/1047 - CCPP Framework will no longer support unit "flashes 5 min-1"
    • Hold off merging feature/capgen into main?
    • Easiest way is to extend the long name and change the units? Will come in via a PR before unification (not anytime soon)
  • SCM testing with capgen?
    • caps generation ok for SCM + GFS v16, build system all hooked up, but code doesn't build (module name differences, problematic for modules with derived data types)
    • More features in capgen will need changes in CCPP physics - for example, Fortran parser cannot parse deferred array shapes (e.g. arr(-lsoil:+lsoil))
    • Max W's regex changes should help with that (in units checker in feature/capgen branch)
    • Another modification of regex needed to allow underscores in units (e.g. degrees_north)

Updates from last time

  • Dom working on converting blocked data structures to contiguous arrays for the UFS
    • So far converted about half of the DDTs used in the physics

Other business

Clone this wiki locally