Skip to content

CCPP Framework Meeting Minutes 2024 04 15

Jump to bottom
Courtney Peverley edited this page Apr 15, 2024 · 3 revisions

Agenda

Attendees: Mike Kavulich,

GitHub issues/PRs

CCPP Framework (issues, PRs, discussions)

Standard names (issues, PRs, discussions)

New items for discussion

Updates from last time

Previous notes

Other business

Meeting notes

CCPP Framework

  • Issue #553 - Michael K to add thoughts; other to chime in as desired
  • PR #555
    • Michael to respond to Steve’s comments
    • Dustin to also review
  • PR #556 - add missing MPI target in src/CMakeLists.txt
    • Approved
    • Dustin - was working in SCM because it was using wrapper compilers that already had MPI linked in
    • Will be merged in when UFS testing is done
    • Michael K/Grant to bring up at next bi-friday meeting to be combined with next UFS PR

Standard Names

  • Issue #57: feedback on meaning of sea_ice_area_fracton_of_sea_area_fraction
    • Michael K to update issue/get discussion up to date
    • There’s a lot more in the issue - Michael K to take a look if something has been missed that needs to be addressed
  • Issue #58: variable name changing policy and procedures
    • Michael K to add to wider meeting
    • Dom - start with what we have and solicit feedback in PR?
    • Dom to open PR
  • Issue #61: clarification regarding _at_interface suffix
    • Addressed in PR#65
      • Dom: Remove all; other than that we’re ok
        • Other people should chime in to agree/disagree on removal of “all”
        • Cheryl to chime in with agreement
      • Michael K to prioritize his review
  • PR #62: update standard name rules for dimensionless units
    • “frac” -> “fraction”
    • Re-review requested from Jesse
  • Issue #63 - dealing with unusual units
    • Units of 1 is sometimes used as a catch-all (e.g. ln(Pa))
    • Dom - remembering discussion from a few years ago - what does ln(Pa) mean?
    • Michael K - technically a correct unit, but definitely a weird one
    • Cheryl - would vote for one-off weird units of 1
    • Dustin - this would actually be a simple conversion
    • Courtney - what if one scheme had it in ln(mb) and another had ln(Pa) - those aren’t equivalent and would cause wrong answers if we had units = 1 for both.
    • Michael W - check other unit conversion libraries - how do they handle ln units?
      • Would make things easier if we ever decide to externalize our unit conversion library
    • Dom - how common are these types of units? Is this worth the effort for an edge case?
      • Courtney - would vote for not implementing a converter, but updating the unit from 1 to “ln(Pa)”
    • Capgen can’t handle ln(Pa), so we’d have to update the regex (or possibly skip the check entirely?)
      • Michael K to look into this
      • Cheryl - could update to ln_Pa (generally agreement on this)
  • Issue #64: need to replace the use of “volumetric” with “volume_fraction” when referring to soil quantities
    • Hopefully a straight-forward correction; waiting on PR from Jesse

Discussion

  • Dustin: Should prioritize efforts
    • Specifically, Dom has a few things going on, so want to use his time as best as possible before he moves to the Navy
    • Dom had issues with deferred-length characters with older version of GNU compiler
    • Will have conflicts between Dom’s work and Dustin’s work; Dustin working to get SCM stuff up to dates optional arguments updates

CCPP Framework wiki

Clone this wiki locally